Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Drupal currently builds CSS with PostCSS 7, but PostCSS 8 is available and most plugins have been upgraded to support it.
Steps to reproduce
Proposed resolution
Upgrade to PostCSS 8.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
PostCSS has been upgraded from 7.0.39 to 8.4.16. Developers who used custom PostCSS plugins may need to refer to the PostCSS 8 plugin migration guide.
Comment | File | Size | Author |
---|---|---|---|
#28 | core-3261163-28--10x.patch | 333.54 KB | nod_ |
| |||
#25 | 3261163-25--10x.patch | 333.68 KB | bnjmnm |
| |||
#20 | 3261163-20-95x.patch | 349.16 KB | bnjmnm |
#20 | 3261163-20-10x.patch | 333.67 KB | bnjmnm |
#14 | 3261163-14-95x.patch | 64.34 KB | Spokje |
Comments
Comment #2
longwaveMost differences are around output order of CSS rules, and
postcss-calc
now seems to precalculate the result when the units match. Also, the way you define plugins has changed so our custom removeUnwantedCommentsFromVariables plugin is different.Two issues:
1.
postcss-header
has not been updated so there is a warning on build; I suggest we just pull this directly into the build script as it's only a few lines of code.2.
postcss-url
doesn't seem to inline all SVGs any more, only some of them.Comment #3
longwaveComment #4
longwavepostcss-header
has been updated, andpostcss-url
seems to be fixed now, so the output is now better than #2.In these patches I haven't dealt with the deprecation for the removeUnwantedCommentsFromVariables plugin, I think maybe we should do that in a followup to keep rerolling this simple.
Patches created with
Comment #6
bnjmnmThe 95 patch has changes to core.libraries.yml that seem unexpected. These happen after
yarn build
so I'm wondering if a build step that would have called vendor update was missed in #3306182: Update to latest minor and patch versions of JavaScript dependencies (except nightwatch and cspell).Comment #7
longwaveOpened #3308458: core.libraries.yml is out of sync in 9.5.x for #6.
Comment #8
lauriii#3308458: core.libraries.yml is out of sync in 9.5.x is in.
Comment #9
lauriiiComment #10
SpokjeComment #11
SpokjeCan for the life of me not get a non-empty interdiff between the old and rerolled
10x
patches.Could be because of the
Patch Failed to Apply
of the old one.Anyway, attached a raw-diff (and yes, I even remembered to do a
yarn build
this time... 😈)Comment #12
SpokjeComment #13
SpokjeNo clue what's up with #12, I just re-did ayarn build
and that patch and had no changes.Never mind, there _are_ changes. Somehow on my machine yarn build seems to be doing things in parallel and not be very good at it.
It returns as being ready, but some tasks come in later.
Anyway, both 10x and 95x are getting a lot of:
So I _think_ it needs work anyway?
Comment #14
SpokjeComment #15
Spokje#14 passed the Custom commands phase, keeping this on NW because of (at least)
10.0.x
and10.1.x
are giving a lot of messages like the one belowComment #16
longwaveIn #4 I proposed dealing with that deprecation in a followup, but I also don't mind doing it here if we think that is necessary.
Comment #17
Spokje@longwave: Ah, thanks for pointing that out, completely overlooked your comment.
Comment #18
lauriiiBased on #16 and #17, it sounds like this needs review.
Comment #19
Wim LeersThis needs a reroll due to #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies having landed ~4 hours ago.
Comment #20
bnjmnmReroll
Comment #21
longwaveNeeds followup for "remove-unwanted-comments-from-variables: postcss.plugin was deprecated."
Comment #22
bnjmnmFollowup created #3308872: Address "postcss.plugin was deprecated" warning
Comment #23
nod_all good
Comment #24
lauriiiIt looks like the 10.0.x patch needs another reroll 😅
Comment #25
bnjmnmHere's another 10x. 9x in #20 seems to still be OK.
Comment #26
longwaveDiff between #20 and #25 is only context in package.json and an autoprefixer patch release in yarn.lock, back to RTBC.
edit: was already RTBC, but I had the tab open from earlier!
Comment #27
lauriii10.0.x needs another reroll now that #3269082: Remove HTML5 details collapse polyfill has landed. 🤪
Comment #28
nod_conflict was in olivero details.css file
Comment #31
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and the respective patch to 9.5.x, thanks!
Comment #32
phenaproximaThis dependency update (yes, even dev dependencies, apparently...I don't make the rules) should have a release note. :)
Comment #33
longwaveAdded a short release note with a link to the plugin migration guide.
Comment #34
longwaveComment #35
phenaproximaPerfect.