Remove deprecated views module functions

Needs #3261486: Remove core updates added prior to 9.3.0 and adjust test coverage to land first.

Found another one.

$ grep -r "@trigger" core | grep -v "node_modules" | grep -v views_ui | grep -i views
core/modules/views/src/Plugin/views/relationship/RelationshipPluginBase.php:      @trigger_error($this->definition['deprecated'], E_USER_DEPRECATED);
core/modules/file/src/Plugin/views/field/File.php:      @trigger_error('Calling File::__construct() without the $file_url_generator argument is deprecated in drupal:9.3.0 and the $file_url_generator argument will be required in drupal:10.0.0. See https://www.drupal.org/node/2940031', E_USER_DEPRECATED);

Unrelated fail in QuickEditFileTest.

+++ /dev/null
@@ -1,143 +0,0 @@
-
-  /**
-   * Loads a test view.
-   *
-   * @param string $view_id
-   *   The view config ID.
-   *
-   * @return \Drupal\views\ViewEntityInterface
-   *   A view entity object.
-   */
-  protected function loadTestView($view_id) {
-    // We just instantiate the test view from the raw configuration, as it may
-    // not be possible to save it, due to its faulty schema.
-    $config_dir = $this->getModulePath('views') . '/tests/fixtures/update';
-    $file_storage = new FileStorage($config_dir);
-    $values = $file_storage->read($view_id);
-    /** @var \Drupal\views\ViewEntityInterface $test_view */
-    $test_view = $this->container
-      ->get('entity_type.manager')
-      ->getStorage('view')
-      ->create($values);
-    return $test_view;
-  }
-

I think we should probably keep this in core with no tests methods, so it can be used for the next views update. There may already be one in 10.x since the patch was created.

Bringing back ViewsConfigUpdaterTest::loadTestView as @catch suggested.

Obs.: The diff is a bit off because I had to do a small reroll (as views.view.test_user_multi_value.yml and ViewsConfigUpdaterTest.php had some alterations (commits) since last patch).

Sorry, I didn't pay attention to the PHPStan check and missed an error.

use ($view) was removed from ViewsConfigUpdater::updateAll since it wasn't being used, but the following line was added to updateAll on commit 9f17ffb15e (Issue #3173180).

      if ($this->processImageLazyLoadFieldHandler($handler, $handler_type, $view)) {
        $changed = TRUE;
      }

So I added back use ($view) to the method caller.

The only fail on patch #22 is:

1) Warning
No tests found in class "Drupal\Tests\views\Kernel\ViewsConfigUpdaterTest".

Which was expected since @catch asked to "keep this in core with no tests methods" (#20) so sending back to NR.

Should a new Trait be created with the loadTestView function in this case?

Maybe we could keep a stub test method with ::markTestSkipped() or a dummy assertion - the main reason to leave this in is because I am pretty sure we will need it again within weeks or at the most months.

Addressed #26.
Please review.

Ops. I forgot to add 'test' before the function name.

1. We are keeping the class ViewsConfigUpdate, therefor the following comment needs to be changed:

    *   This class is only meant to fix outdated views configuration and its
    *   methods should not be invoked directly. It will be removed once all the
    *   deprecated methods have been removed.
    */
   class ViewsConfigUpdater implements ContainerInjectionInterface {
   

2. We are removing the plugin node_path, only it is still used in modules/views/tests/modules/views_test_config/test_views/views.view.test_destroy.yml:

   path:
     field: path
     id: path
     table: node
     plugin_id: node_path
     entity_type: node
   

3. +++ b/core/modules/views/src/ViewsConfigUpdater.php
   @@ -189,300 +176,6 @@ protected function processDisplayHandlers(ViewEntityInterface $view, $return_on_
   -      @trigger_error(sprintf('The entity link url update for the "%s" view is deprecated in drupal:9.0.0 and is removed from drupal:10.0.0. Module-provided Views configuration should be updated to accommodate the changes described at https://www.drupal.org/node/2857891.', $view->id()), E_USER_DEPRECATED);
   

   We are removing this deprecation warning. Can the suppression of this warning be removed from tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php?

4. +++ b/core/modules/views/src/ViewsConfigUpdater.php
   @@ -189,300 +176,6 @@ protected function processDisplayHandlers(ViewEntityInterface $view, $return_on_
   -      @trigger_error(sprintf('The operator defaults update for the "%s" view is deprecated in drupal:9.0.0 and is removed from drupal:10.0.0. Module-provided Views configuration should be updated to accommodate the changes described at https://www.drupal.org/node/2869168.', $view->id()), E_USER_DEPRECATED);
   

   The same for this deprecation warning. See previous item.

A new patch trying to address the points on #30

All my points have been addressed.
All code changes look good to me.
For me it is RTBC.

Committed 55e559e and pushed to 10.0.x. Thanks!