Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
https://github.com/minkphp/Mink/issues/822
Steps to reproduce
Proposed resolution
Remaining tasks
If this does not happen before 10.0.0-beta1, add the Friendly version to the core dependency list.
User interface changes
API changes
Data model changes
Release notes snippet
The Mink dev dependencies friends-of-behat/mink
and friends-of-behat/mink-browserkit-driver
have been switched back to their upstream versions at behat/mink
and behat/mink-browserkit-driver
respectively now that upstream has resolved Symfony 6 compatibility issues.
Comment | File | Size | Author |
---|---|---|---|
#20 | 3264903-20.patch | 14.93 KB | Spokje |
| |||
#20 | interdiff_16-20.txt | 442 bytes | Spokje |
Comments
Comment #2
catchComment #3
catchIf we're not able to switch back prior to beta, we should use this issue to update https://www.drupal.org/about/core/policies/core-dependency-policies/core... instead.
Comment #4
longwaveComment #5
xjmComment #6
murilohp CreditAttribution: murilohp at CI&T commentedHey, today mink has made a new release! This release is compatible with SF6 So I think it's fine to switch back from friends-of-behat/mink.
Comment #7
xjmComment #9
murilohp CreditAttribution: murilohp at CI&T commentedOoops forget to update some files
Comment #10
SpokjeJust wondering about 2 things:
Where does the "bonus"
'driver-testsuite'
come from?Where only 1. is directly related to this issue.
Comment #11
longwavedriver-testsuite
can be removed. It was a directory of test code, originally present in https://github.com/behat/Mink but is no longer there in https://github.com/minkphp/Mink which is the current source.There was also a Symfony 6 compatible release of
behat/mink-browserkit-driver
so I think we could switch both at the same time if we wanted.Comment #12
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedI have removed
driver-testsuite
as per comment #11.Comment #13
murilohp CreditAttribution: murilohp at CI&T commentedThanks for the reviews, @Spokje and @longwave and for updating the patch(@ravi.shankar), here's a new one, I had to reroll #12, I've removed
driver-testsuite
fromcore/lib/Drupal/Core/Composer/Composer.php
and replacedfriends-of-behat/mink-browserkit-driver
withbehat/mink-browserkit-driver
, following #11 suggestion.Comment #14
murilohp CreditAttribution: murilohp at CI&T commentedComment #15
longwaveLet's keep this in alphabetical order to make it easier to find packages.
Comment #16
murilohp CreditAttribution: murilohp at CI&T commentedMakes sense @longwave, addresing your suggestion here
Comment #17
murilohp CreditAttribution: murilohp at CI&T commentedJust updating the composer.json to let the packages in alphabetical order.
Comment #20
SpokjeDrupal\Tests\ComposerIntegrationTest::testComposerLockHash
always is my nemesis as well.Comment #21
longwaveThank you. Added a release note snippet.
Comment #23
catchCommitted/pushed to 10.0.x, thanks!
I was thinking about 9.4.x backport but it'd be just an update of dev dependencies in 9.4.x, so I think we can handle that in an 'update all the things' issue.
Comment #24
murilohp CreditAttribution: murilohp at CI&T commentedThanks for fixing this issue @catch! Now we need a review on #3252304: Implement elementAttributeNotExists in WebAssert.php, this issue will address the new feature implemented on mink.