Problem/Motivation

https://github.com/minkphp/Mink/issues/822

Steps to reproduce

Proposed resolution

Remaining tasks

If this does not happen before 10.0.0-beta1, add the Friendly version to the core dependency list.

User interface changes

API changes

Data model changes

Release notes snippet

The Mink dev dependencies friends-of-behat/mink and friends-of-behat/mink-browserkit-driver have been switched back to their upstream versions at behat/mink and behat/mink-browserkit-driver respectively now that upstream has resolved Symfony 6 compatibility issues.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

catch’s picture

catch’s picture

If we're not able to switch back prior to beta, we should use this issue to update https://www.drupal.org/about/core/policies/core-dependency-policies/core... instead.

longwave’s picture

Title: Switch from friends-of-mink back to mink once it's Symfony 6 compatible » Switch from friends-of-behat/mink back to behat/mink once it's Symfony 6 compatible
xjm’s picture

Issue summary: View changes
murilohp’s picture

Hey, today mink has made a new release! This release is compatible with SF6 So I think it's fine to switch back from friends-of-behat/mink.

xjm’s picture

Priority: Normal » Major
Issue tags: +Drupal 10, +Needs release note

Status: Needs review » Needs work

The last submitted patch, 6: 3264903-6.patch, failed testing. View results

murilohp’s picture

Status: Needs work » Needs review
FileSize
9.97 KB
1.47 KB

Ooops forget to update some files

Spokje’s picture

Just wondering about 2 things:

  1. --- a/composer/Plugin/VendorHardening/Config.php
    +++ b/composer/Plugin/VendorHardening/Config.php
    @@ -20,6 +20,7 @@ class Config {
        * @var array
        */
       protected static $defaultConfig = [
    +    'behat/mink' => ['tests', 'driver-testsuite'],
         'behat/mink-selenium2-driver' => ['tests'],
         'composer/composer' => ['bin'],
         'drupal/coder' => [
    @@ -29,7 +30,6 @@ class Config {
         'doctrine/instantiator' => ['tests'],
         'easyrdf/easyrdf' => ['scripts'],
         'egulias/email-validator' => ['documentation', 'tests'],
    -    'friends-of-behat/mink' => ['tests'],
         'friends-of-behat/mink-browserkit-driver' => ['tests'],
         'guzzlehttp/promises' => ['tests'],
         'guzzlehttp/psr7' => ['tests'],
    

    Where does the "bonus" 'driver-testsuite' come from?

  2. Can/Should we also switch back to https://packagist.org/packages/behat/mink-browserkit-driver?

Where only 1. is directly related to this issue.

longwave’s picture

Status: Needs review » Needs work

driver-testsuite can be removed. It was a directory of test code, originally present in https://github.com/behat/Mink but is no longer there in https://github.com/minkphp/Mink which is the current source.

There was also a Symfony 6 compatible release of behat/mink-browserkit-driver so I think we could switch both at the same time if we wanted.

ravi.shankar’s picture

I have removed driver-testsuite as per comment #11.

murilohp’s picture

Thanks for the reviews, @Spokje and @longwave and for updating the patch(@ravi.shankar), here's a new one, I had to reroll #12, I've removed driver-testsuite from core/lib/Drupal/Core/Composer/Composer.php and replaced friends-of-behat/mink-browserkit-driver with behat/mink-browserkit-driver, following #11 suggestion.

murilohp’s picture

Status: Needs work » Needs review
longwave’s picture

+++ b/composer/Plugin/VendorHardening/Config.php
@@ -29,8 +30,7 @@ class Config {
-    'friends-of-behat/mink' => ['tests'],
-    'friends-of-behat/mink-browserkit-driver' => ['tests'],
+    'behat/mink-browserkit-driver' => ['tests'],

+++ b/core/lib/Drupal/Core/Composer/Composer.php
@@ -17,14 +17,14 @@
-    'friends-of-behat/mink' => ['tests'],
-    'friends-of-behat/mink-browserkit-driver' => ['tests'],
+    'behat/mink-browserkit-driver' => ['tests'],

Let's keep this in alphabetical order to make it easier to find packages.

murilohp’s picture

Makes sense @longwave, addresing your suggestion here

murilohp’s picture

FileSize
14.93 KB
13.7 KB

Just updating the composer.json to let the packages in alphabetical order.

The last submitted patch, 13: 3264903-13.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 17: 3264903-16.patch, failed testing. View results

Spokje’s picture

Status: Needs work » Needs review
FileSize
442 bytes
14.93 KB

Drupal\Tests\ComposerIntegrationTest::testComposerLockHash always is my nemesis as well.

longwave’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs release note

Thank you. Added a release note snippet.

  • catch committed 1b0a476 on 10.0.x
    Issue #3264903 by murilohp, Spokje, ravi.shankar, catch, longwave:...
catch’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +10.0.0 release notes

Committed/pushed to 10.0.x, thanks!

I was thinking about 9.4.x backport but it'd be just an update of dev dependencies in 9.4.x, so I think we can handle that in an 'update all the things' issue.

murilohp’s picture

Thanks for fixing this issue @catch! Now we need a review on #3252304: Implement elementAttributeNotExists in WebAssert.php, this issue will address the new feature implemented on mink.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.