Problem/Motivation
Composer doesn't yet support symfony/console ^6.0. Once it does, we should update both. Should be in the composer 2.3 release.
https://github.com/composer/composer/issues/10322
Steps to reproduce
Proposed resolution
Remaining tasks
See if PSR/log 3 compatibility is possible after the update, and add forward to compatibility to core for its changes.
User interface changes
API changes
Data model changes
Release notes snippet
The symfony/console
component has been updated from version 5.4.3 to 6.0.5. Drupal 10 requires version 6.0 or higher. Additionally, Drupal core's development dependency requirement for the composer/composer
package has been increased from 2.2.4 to 2.3.0.
Issue fork drupal-3264918
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3264918-blocked-on-upstream changes, plain diff MR !1927
Comments
Comment #2
xjmComment #3
xjmComment #4
xjmComment #6
SpokjeComposer 2.3 has a Pre-release which should be testable according to this: https://github.com/composer/composer/issues/10573
I've created an MR which "merely" changes
"composer/composer": "^2.2.4",
to"composer/composer": "dev-main",
incomposer.json
and"symfony/console": "^5.4",
to"symfony/console": "^6.0",
incore/composer.json
.Doing a
composer update composer/composer -W
afterwards gives:Let's feed that to TestBot to see if anything/what breaks.
Comment #8
SpokjeWell that went better than expected!
Seems like besides some side-stepping of our min-stability testing for using a dev release, we are good with Composer 2.3.x if nothing major changes.
I think we only need to wait until the official release is out, change
"composer/composer": "^2.2.4"
, to"composer/composer": "^2.3.0",
incomposer.json
and"symfony/console": "^5.4",
to"symfony/console": "^6.0",
incore/composer.json
and do acomposer update composer/composer -W
afterwards.Also creating a follow-up for the Remaining tasks bit seems in order, if not done already:
Comment #9
SpokjeBesides the random testfailure in
Drupal\Tests\layout_builder\FunctionalJavascript\BlockFormMessagesTest::testValidationMessage
that is plaguing all core tests at the time this testrun was done, it seems that usingcomposer/composer
2.3.0-RC1 and"symfony/console": "^6.0"
is working out fine.The only thing remaining to do is restoring the
MINIMUN_STABILITY
back tostable
incore/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
which is currently set toRC
whenever the official composer 2.3.0 is released.Not saying we _need_ to look at/commit this now, but that we _can_.
Comment #10
SpokjeComment #11
longwaveThanks for keeping this up to date - this is looking promising indeed.
Looking at Composer's release history there has historically been less than two weeks (and sometimes only even one day!) between RC and final, so we can probably wait for 2.3.0.
Comment #12
SpokjeThanks @longwave, I agree.
Postponing on the official Composer 2.3.0 release.
Comment #13
SpokjeComment #14
SpokjeUnpostponing since https://github.com/composer/composer/releases/tag/2.3.0 landed
Comment #15
SpokjeComment #16
SpokjeComment #17
longwaveDependency updates only, no code changes were required, therefore RTBC.
Comment #18
SpokjeMight need CR and release notes?
Comment #19
alexpottI've tagged this issue in the CR https://www.drupal.org/node/3265441
We should open a follow-up to see if psr/log v3 is supportable now.
Committed 1b79d50 and pushed to 10.0.x. Thanks!
Comment #22
SpokjeThanks @alexpott, created #3272447: Update to PSR/log v3 as a follow-up
Comment #23
xjmComment #24
xjmFor dep updates, we always want release notes, but almost never need a CR unless there is also an API change in Drupal APIs because of it. :)
Comment #25
andypostThere's bugfixed version released
https://github.com/composer/composer/releases/tag/2.3.2