Problem/Motivation

jsdom could be updated from 18.1.1 to 19.0.0.

Proposed resolution

Update jsdom to latest releases and backport to 9.4.x.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

jsdom has been updated from 18.1.1 to 19.0.0.

Issue fork drupal-3265664

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

jsdom looks like a trivial update: https://github.com/jsdom/jsdom/blob/master/Changelog.md#1900

On the other hand, chalk needs work, as it needs to be loaded a different way: https://github.com/chalk/chalk/releases/tag/v5.0.0

But there is a note: "It's totally fine to stay on Chalk v4. It's been stable for years." - so I don't think this is critical for 9.4.x/10.0.x.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Looking at this a bit more, in order to migrate to chalk 5 I think we have to convert all our scripts from CommonJS to ESM as per https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer and at Acquia commented

I think we can probably make it happen with the updated nodejs version and nightwatch 2. From what I remember nightwatch didn't like JS modules which is why everything is old school in the repo.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer and at Acquia commented
Title: Update chalk and jsdom to latest major release » Update jsdom to latest major release
Issue summary: View changes

let's forget about chalk in this issue. not sure why they were grouped :)

nod_ opened merge request !1884

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer and at Acquia commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

As trivial as can be for JS dependencies :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.4.0 release notes, +10.0.0 release notes

Committed and pushed 708f501cad to 10.0.x and 0a110d3487 to 9.4.x. Thanks!

  • alexpott committed 708f501 on 10.0.x 
    Issue #3265664 by nod_, longwave, lauriii: Update jsdom to latest major...

  • alexpott committed 0a110d3 on 9.4.x 
    Issue #3265664 by nod_, longwave, lauriii: Update jsdom to latest major...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes