Drupal 10 compatibility

I'll work on this.

I updated the .info file adding the Drupal 10 compatibility. Kindly review it :)

I will try to help in it.

I run the Drupal check and the error below came, so just after fix this problem will be possible to go through it.

Child process error (exit code 255): PHP Fatal error: During class fetch: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\Tests\search_api\Functional\ExampleContentTrait not found. in
phar:///app/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/Runtime/RuntimeReflectionProvider.php:185

And also the module csv_serialization is not compatible with Drupal10.

I'll work on this

As said before, the tests need to be fixed. Also, it depends on modules not compatible with Drupal 10. I'll unassign and leave the status as "Needs work".

csv_serialization has a D10 compatible 3.x release, you need to test with that. also the error above means you don't have the require-dev dependency search_api.

That said, composer.json needs to be updated to allow 3.x for csv_serialization.

Or not :)

See #3294354: 3.x composer.json was not updated to require D9/10, blocked by that to test on CI, but you can still check it out locally with git.

Also, the test fails do not even require D10, they fail on D9 too.

Adjusted the assertions for the included header row, as far as I can see this should have been always there. Maybe #3087166: Unable to Override Headers/Labels with hook_views_pre_render() changed something? not sure.

I'll review this

I reviewed and those are my observations about this issue:

1 - I installed the module and checked out to the branch related to this issue.
2 - At first, when i ran the tests, there were some errors because it was missing some required modules.
3 - I cloned the repository from the following modules: csv_serialization, xls_serialization e search_api.
4 - After that, the tests were still breaking, so I had to make some changes in the Xls.php file of the xls_serialization module (lines 53 and 153).
5 - Afther those changes, all tests passed.
6 - I also runned "phpcbf" command to fix auto-fixable coding standards errors, then commited and pushed those changes.

I changed the status to "Reviewed & tested by the community" but i am not sure if it is OK, since there is still tests failures untill the problem mentioned on (4) be solved.

> 6 - I also runned "phpcbf" command to fix auto-fixable coding standards errors, then commited and pushed those changes.

This is not on scope, coding standards should only be fixed/ensured on code that is touched by the patch. If you do the same in 3 different issues then they will conflict, making the process harder.

Also, making changes prevents you from RTBC'ing an issue as you should not do that for an issue that you worked on yourself.

xls_serialization has its own RTBC issue that just needs to be committed. It makes sense for that to happen first, but it's not a blocker to set this to RTBC.

Thanks for the feedback @Berdir, i am new to the drupal community and still learning about the contribution proccess, Should I change the status to "Needs review" then?

My suggestion would be to revert your commit, then you're technically allowed to mark it as RTBC again and then you can leave it again.

It's not a huge deal, not if it's only a few changes but core for example tends to be more strict about it.

Tagging and noting the bot patch.

#3299442: Automated Drupal 10 compatibility fixes

Moving back to needs review based on #23.