Drupal 10 readiness meeting / 7 March 2022 [#3267083]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3267083`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

lauriii	Hello :wave:
xjm	:wave: xjm, core release manager
mglaman	:wave: hello
dww	:wave: Derek from TEN7, core subsystem maintainer & contributor... (edited)
catch	Nat. Not really here until later.
bircher	:wave:
longwave	:wave: Dave, UK
larowlan	Lee
shaal	Hello :sunglasses:
Gábor Hojtsy (he/him)	Gábor, Drupal 10 coordinator
kimb0	Kim, AU
quietone	Hi
el7cosmos	Hello
Kristen Pol (she/her)	Kristen, California, catching up
Ilcho Vuchkov (vuil)	Ilcho, Bulgaria EU, I follow the updates…

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we'll open threads for them as appropriate.

xjm	I have a list of potentially actionable JavaScript issues that initiative contributors could help with. Maybe a subthread for each?Remove jQuery cookie from 10.0.x (already deprecated in D9) (needs issue)Remove Joyride from 10.0.x (already deprecated in D9) (needs issue)Deprecate IE11 polyfills: #3239796: [meta] Remove dependency on Underscore.js outside of Backbone and mark it internal
mglaman	Starterkit, any tooling stuff
xjm	Oh also, let's talk color.module
bircher	I think the link to the agenda is wrong because I added last time the following for this weeks meeting: Bringing the dependency injection container more in line with Symfony #3021900: Bring new features from Symfony 3/4/5/6 into our container
Gábor Hojtsy (he/him)	@bircher thanks, yeah the link is wrong, but your item is not forgotten :slightly_smiling_face:
xjm	Yeah, I added an item for PHP unit 10 compatibility also (edited)
Kristen Pol (she/her)	Description notes meetings are every other Monday… change to weekly for now?
Gábor Hojtsy (he/him)	I changed it in next weeks' so it will be properly cloned from there.
ambermatz	:question:For experimental Help Topics module, we have 4 remaining issues in our roadmap to stable. (#3027054: Help Topics module roadmap: the path to beta and stable) Has the window closed for D10? If not, what would the date be for that “closed window”?
Gábor Hojtsy (he/him)	@ambermatz it definitely did not close yet, I think it would be the beta release which is a little over two months from now earliest

2️⃣ Potentially actionable JavaScript issues for contributors

xjm	Please sign up for any of the below :slightly_smiling_face: There's various levels of JS knowledge needed, but if we could have people put their hand up for each that would be great
Kristen Pol (she/her)	https://twitter.com/kristen_pol/status/1501061659883827207?s=20&t=D9w3Gy...

2️⃣ .1️⃣ Remove jQuery cookie from 10.0.x (already deprecated in D9) (needs issue)

xjm	This should probably be straightforward, just remove the library definition, the vendor assets, associated build code, etc.
xjm	The issue should be filed as a child of #3238507: Drupal 10 JavaScript dependency plan
xjm	There's also possibly a BC layer to remove (edited)
murilohp	Hey, since you brought the jQuery cookie, I worked on this issue, and it would be nice to have a review there

2️⃣ .2️⃣ Remove Joyride from 10.0.x (already deprecated in D9) (needs issue)

xjm	Basically all the same things I said on https://drupal.slack.com/archives/C014CT1CN1M/p1646680295187269
murilohp	I've created the following issue to address this: #3268228: Remove Jquery joyride

2️⃣ .3️⃣ Deprecate IE11 polyfills

Gábor Hojtsy (he/him)

#3263823: Empty out and deprecate drupal libraries which are related to Internet Explorer 11 polyfills in 10.0.x for removal in 11.0.0

2️⃣ .4️⃣ Deprecate and remove Modernizr

Gábor Hojtsy (he/him)	#3239980: Deprecate Modernizr
xjm	This one has had some exploration about removing the library, but we need to deprecate it in 9.4 first

2️⃣ .5️⃣ Update core eslint configuration

Gábor Hojtsy (he/him)	#3239838: Update core eslint configuration to remove unused React and JSX rules
xjm	This one doesn't have any work on it yet, but there are high-level instructions in the IS
longwave	I worked on the ESLint 8 upgrade so I might have a go at this one too

2️⃣ .6️⃣ Decouple from Underscore and mark it internal

Gábor Hojtsy (he/him)	#3239796: [meta] Remove dependency on Underscore.js outside of Backbone and mark it internal
xjm	Another good choice if someone wants to start from the beginning of the task :slightly_smiling_face:
xjm	We think the scope of this is fairly small

3️⃣ Starterkit theme / tool

mglaman	waiting for feedback on #3206217: Allow starterkit themes to control how the theme is generated
mglaman	OH I didn’t see someone comment on the MR
mglaman	and working to play reviewer for @danflanagan8’s awesome test work #3083275: [meta] Update tests that rely on Classy to not rely on it anymore
danflanagan8	And playing reviewer mighty well at that
mglaman	thanks!
lauriii	also didn’t see the MR comments.. will check tomorrow :+1:
mglaman	I gave my feedback, and seeing how to get GitLab emails beyond “YOU MADE AN MR!” spam
larowlan	It's in notification settings in gitlab
larowlan	Actually really decent
mglaman	Maybe I just missed it, it’s set to “Participate.” Might have assumed it was the normal “opened an MR” email (edited)
dww	I also hope to get back to writing and reviewing issues for removing classy from tests. But I'm way over committed right now, and can't make any promises. Thanks @danflanagan8 for breathing life back into the effort!
lauriii	left some comments on the starterkit theme generator issue

4️⃣ PHPStan / Rector tooling updates

Gábor Hojtsy (he/him)	@mglaman raised this
mglaman	We need folks to run drupal-rector and find over zealous code refactors or items missed
mglaman	which I don’t know if that’s going to be very feasible
Gábor Hojtsy (he/him)	Ideally we could update the project update bot to run the latest rector and fix the info files proper. I did not find time for that unfortunately :/
mglaman	I know it’s mostly closed, is there anyway to give a hand with that?
Gábor Hojtsy (he/him)	@mglaman yeah I think that is the kind of stuff you would find fun :slightly_smiling_face:
Gábor Hojtsy (he/him)	@mglaman it involves setting up a drupalci vm locally https://www.drupal.org/drupalorg/docs/drupal-ci/running-drupalci-locally
mglaman	I've run it locally a bit before. But I'd be interested
Gábor Hojtsy (he/him)	so that VM has a checkout of https://git.drupalcode.org/project/infrastructure
Gábor Hojtsy (he/him)	and the all-contrib job is at https://git.drupalcode.org/project/infrastructure/-/tree/main/stats/proj...
Gábor Hojtsy (he/him)	https://git.drupalcode.org/project/infrastructure/-/blob/main/stats/proj... produces a tsv file, that you can take from the jenkins job and use an abbreviated version of (just a few projects that are rectorable), so you don’t need this round-trip :slightly_smiling_face:
Gábor Hojtsy (he/him)	https://git.drupalcode.org/project/infrastructure/-/blob/main/stats/proj... runs the analyzer (upgrade status)
Gábor Hojtsy (he/him)	then https://git.drupalcode.org/project/infrastructure/-/blob/main/stats/proj... is where the phpstan results and rector patches get generated and the logic is ran to figure out if a patch should be generated, etc.
Gábor Hojtsy (he/him)	@mglaman so maybe the last two scripts are really where you can see how its happening :slightly_smiling_face:
mglaman	huh, I never realized the vagrant machine installed infrastructure, but it’s also been like 2 years
mglaman	Okay, I’ll come back to this thread and write up notes and give it a try
Kristen Pol (she/her)	Is this documented anywhere else… even just in an issue? Seems like useful instructions
Gábor Hojtsy (he/him)	There could be a section on https://www.drupal.org/drupalorg/docs/drupal-ci/running-drupalci-locally

5️⃣ Bring new features from Symfony 3/4/5 into our container

Gábor Hojtsy (he/him)	Raised by @bircher #3021900: Bring new features from Symfony 3/4/5/6 into our container
catch	Most of the child issues are stuck at needs review. I haven't checked recently but would think they could all be committed to minor releases.
xjm	Yeah this is minor work, not major work
xjm	Not a D10 blocker and can be done at any time
xjm	So I guess just a matter of prioritizing and getting reviews
xjm	But it could go into 9.4 (for SF 3 and 4 features) or 10.1 (for SF 5+)
xjm	We might even be able to add some forward-compatibility depending on the nature of the SF5 features
longwave	I am +1 for all issues here, but there doesn't seem to be much interest in moving it forward
longwave	Also would be interested in any new features that other Symfony components provide that might be useful to core
larowlan	Would also love to see controller injection work like sf4+
larowlan	But that needs autowiring first
longwave	Autowiring is supported but we need to alias all of our services with their interface name for it to work across core, I worked on this last year but the issue never really got reviewed I think
longwave	Maybe we should autowire something small as proof of concept instead before rolling it out across all of core

6️⃣ PHPUnit 10 compatibility

Gábor Hojtsy (he/him)	Raised by @xjm
xjm	Meta is #3217904: [meta] Support PHPUnit 10 in Drupal 11
xjm	One outstanding child at #3125809: Remove usages of \PHPUnit\Framework\TestListener once PHPUnit 9 support is dropped is postponed -- not sure what the next step is
longwave	Not sure there is much actionable here - PHPUnit 10 has been delayed for some time and until there is an alpha release there are likely more important tasks to work on
xjm	The concern is that the alpha might come out while we're in beta -- so if we can resolve as much as possible ahead of time against the dev branch that would be good
xjm	They're at 85% of the milestone
xjm	Per @effulgentsia we were stuck previously on some as-yet-unresolved issue (I forget what it was)
longwave	At least two of the incomplete milestone items are needed by us (event system, ResultPrinter)
longwave	I think event system is the thing that replaces TestListener
longwave	it is also unclear now when support for PHPUnit 9 will end, but i would hope that given the delay in PHPUnit 10 we have at least 1 year if not 2: https://phpunit.de/supported-versions.html

7️⃣ Removing color module!

Gábor Hojtsy (he/him)	Raised by @xjm
xjm	So one person has pushed back based on the fact that there's a feature request to add color support to Olivero, but that issue is not a Standard blocker, and we need to get Farbtastic out of core one way or another
xjm	I think there's a pretty strong case to move color to contrib with its current dependencies as BC -- any theme can add a dependency on it -- and then allow Olivero to propose next-gen color APIs or UIs for core that have been worked on in various issues
xjm	@webchick has raised before on the issue that the current UI might actually be hurting us because it's not up to date with user expectations, and it also has accessibility problems of its own
xjm	So we could use more feedback on the issue, especially from all the people who +1ed in Slack :slightly_smiling_face: and also a Product Management review
Gábor Hojtsy (he/him)	Olivero is not adding color support using color module as it was not possible to change in a way that made sense for a modern theme like Olivero. (edited)
Gábor Hojtsy (he/him)	@mherchel can fill us in more :slightly_smiling_face:
Gábor Hojtsy (he/him)	but basically Olivero should not be counted as a reason to keep color module and once we remove Bartik is there any core theme using/supporting color module?
xjm	Forgot the issue link #2808151: [policy] Move the Color module to a contributed project when Bartik is deprecated
mherchel	in a meeting will respond shortly
larowlan	+1 for removal fwiw
mherchel	FYI, we're not making use of the color module in Olivero. We're doing some custom work that takes one user input color, and then generates a number of derivative colors to make an entire palette. That's something that the color module will never do.
xjm	@mherchel, could you reply on the issue regarding it? Thanks!