Convert to JSON data storage (D9)

Could/should we do this on D7 too?

FYI the TMGMT module made this change: #3065597

WIP, untested.

I think we should go the additional step and store the data as a JSON field rather than just store it as a different string format, that would give us the most benefit.

The migration logic needs to support both Metatag 7.x-1-x-style serialized arrays and Metatag 7.x-2.x-style JSON data.

Some fixes.

This should fix some of the test failures.

This should fix the last error.

Excellent.

I've updated the Remaining Tasks list:

• Update D7 migrations to support JSON for compatibility with #3273408.
• Add an update script to update existing configuration.
• Add an update script to update stored entity data.

Note: this doesn't change the underlying field itself, it just changes how the data is stored in the field.

Did some manual testing and it works well, it's nice having the data stored in JSON format instead of serialized arrays.

Seeing how this would work if it didn't serialize the data..

Rerolled.

I suspect we might need #3320031: Add a new field for storing raw JSON data (D9) before we can handle JSON all the way down..

This is #14 rerolled, with a fix for an unwanted second argument to Json::decode().

Does this fix it?

One more..

Woot.

Let's set up the D7 migration to have a JSON-encoded value alongside a serialized value.

Offload the migration decoder logic to a separate method, and mirror the code from D7.

Nice!

That's two items down, now to do update scripts.

Let's make backwards compatibility a little easier by adding the same global function that the D7 issue uses. Yes, a function.

WIP update script, not running the tests because there's no test coverage for that bit yet. This also reverts the changes to the info file.

Fixed some typoos.

After doing some testing I've confirmed that on D8+ the configuration items do not need to be modified, they're stored as a single object with multiple values in the "tags" element instead of those values being stored as a serialized array. That means we don't need to update the configuration. Woot.

Rerolled.

The test failures are because of WebProfiler, see #3323467 for details.

All that's left is to finish up the update script.

I think we need test coverage to make sure that data loads correctly in both the v1 and v2 field formats, to make sure that sites don't break while the update scripts are running.

We need test coverage for the update script too.

Fixed update script.

I can't upload the tests for the update script because it includes a fixture that has a change to the "entity.definitions.installed" and "entity.definitions.installed" key_value records, which include serialized objects, and git thinks the files are binaries and won't output them in the patch file.

Rerolled.

And the tests pass! Woot!

Committed.