Problem/Motivation
10.0.0-alpha4 and 9.4.0-alpha1 will be released next week. Several Composer dependencies can be updated to newer versions.
Proposed resolution
Update Composer dependencies to the latest minor and patch versions prior to 10.0.0-alpha4 and 9.4.0-alpha1.
Remaining tasks
NR.
User interface changes
N/A
API changes
Hopefully not.
Data model changes
N/A
Release notes snippet
10.0.x:
Drupal core's pinned Composer dependency versions have been updated for the latest minor and patch releases. The composer/xdebug-handler
and sebastian/type
dependencies have received major version updates that remove support for PHP versions not supported for Drupal 10.
Other branches:
10.0.x Drupal core's pinned Composer dependency versions have been updated for the latest minor and patch releases. The composer/xdebug-handler
dependency has received a major version update that removes support for PHP versions not supported for Drupal 10.
Comment | File | Size | Author |
---|---|---|---|
#12 | 3278162-12-10.0.x.patch | 74.69 KB | longwave |
#8 | 3278162-8-10.0.x.patch | 79.55 KB | longwave |
| |||
#8 | 3278162-8-9.5.x.patch | 105.79 KB | longwave |
#8 | 3278162-8-9.4.x.patch | 106.09 KB | longwave |
#2 | update-9.4.x.patch | 60.19 KB | xjm |
Comments
Comment #2
xjmComment #3
xjm10.0.x through 9.4.x have minor updates on the polyfills.
Minor updates for 9.4.x. Should we increase constraints for forward-compatibility with the latest minors in case of sec releases? Could be a followup.
Another minor update but probably low-impact.
Comment #5
xjmKnown random fail above in the results. I retested it.
Comment #6
xjmTagging for a follow up for #3. I think we should keep the scope of this issue to doing the lockfile dependency updates for the forward branches.
Comment #7
longwaveThere are a bunch of dev dependencies that can be updated and laminas/laminas-diactoros 2.10.0 is also out.
Comment #8
longwave9.4.x and 9.5.x:
Patches created with
composer update --with=phpunit/phpunit:^8 --with=drupal/coder:8.3.13
10.0.x:
Patch created with
composer update --with=drupal/coder:8.3.13
(Coder update requires more work, see #3262874: Update Coder to 8.3.15)
Comment #9
longwaveThe breaking change here is dropping support for PHP below 7.2.5, which doesn't affect us; as this is a dev dependency only I don't see a problem with a major bump here.
Comment #10
Spokje- TestBot = green
- Got the same results as @longwave when applying the given
composer update
commands.- PHP 7.2 isn't supported by any 9.x/10.x release
RTBC for me.
Comment #11
mallezieThe updates for phpstan (and phpstan-drupal) add new checks, and thus need an updated baseline.
Above patch will fail on a full phpstan run. (For D10 only that is).
See #3278916: Update phpstan/phpstan to latest version.
Might be easiest to leave the phpstan and phpstan-drupal out of this issue, and defer to the other one.
We should do #3259353: Run full phpstan on composer change (or even better #3259355: Always do a full phpstan analysis on DrupalCI)
Comment #12
longwaveRerolled 10.0.x patch with
composer update --with=drupal/coder:8.3.13 --with=phpstan/phpstan:1.4.0 --with=mglaman/phpstan-drupal:1.1.9
#8 is still valid for the 9.x patches.
Comment #14
longwaveRandom fail in WidgetOEmbedTest
Comment #15
mallezieLooks good now to me.
Comment #16
longwaveI think this is critical for 9.4.0-alpha1.
Comment #17
xjmMajor update here that seems to involve dropping PHP 7 support:
https://github.com/sebastianbergmann/type/commit/af0117b3c50858a8669027d...
We need to test these patches on PHP 7 too. I'll queue 'em.
Edit: I'm silly. That was the D10 patch. I thought it was the 9.4 one. Cancelling test runs.
Comment #18
longwaveOops, didn't spot that one, but it's an indirect dependency of PHPUnit only, so I don't think it's an issue for us either. Drupal 10 only supports PHP 8.1, no need to queue PHP 7.x or even 8.0 tests there :)
Comment #19
xjmQueued lower PHP runs for the right patches this time.
Comment #20
xjmConfirmed that it's not being updated in the 9.5.x patch.
Comment #21
xjmWe should document on https://www.drupal.org/about/core/policies/core-dependency-policies/mana... that the baseline needs to be updated (and how to do that) whenever phpstan is updated.
Comment #22
xjmOK, tests are green for the lower PHP versions on the 9.x branches.
Comment #26
xjmCommitted #12 to 10.0.x, and #8 to 9.5.x and 9.4.x. Thanks!
Comment #27
xjmSetting NW for the docs updates.
Comment #28
xjmOh we also need the followups for #3.
Comment #30
Wim LeersFolllow-up for #3 created: #3281578: Increase Composer dependency constraints to latest minors for forward-compatibility.
Which docs need updates?
Comment #31
xjmThe needed docs updates are documented in #21 -- see #11.
Comment #32
Wim LeersI have no idea how or where to document #11.
Comment #33
catchTried that.
https://www.drupal.org/node/3089540/revisions/view/12656316/12658733