Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#14 ultimate_cron-d10-compatibility-3290211-14-interdiff.txt781 bytesBerdir
#14 ultimate_cron-d10-compatibility-3290211-14.patch31.81 KBBerdir
#13 ultimate_cron-d10-compatibility-3290211-13-interdiff.txt4.75 KBBerdir
#13 ultimate_cron-d10-compatibility-3290211-13.patch31.58 KBBerdir
#6 ultimate_cron-d10-compatibility-3290211-6-interdiff.txt3.48 KBBerdir
#6 ultimate_cron-d10-compatibility-3290211-6.patch30.74 KBBerdir
#4 ultimate_cron-d10-compatibility-3290211-4.patch31.07 KBfathima.asmat
#3 ultimate_cron.2.x-dev.rector.patch27.33 KBProject Update Bot
#3 interdiff-last-bot.6645827.txt26.64 KBProject Update Bot
#2 ultimate_cron.2.x-dev.rector.patch1.8 KBProject Update Bot
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Active » Needs review
FileSize
ultimate_cron.2.x-dev.rector.patch1.8 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
FileSize
interdiff-last-bot.6645827.txt26.64 KB
ultimate_cron.2.x-dev.rector.patch27.33 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
fathima.asmat’s picture

fathima.asmat CreditAttribution: fathima.asmat at CTI Digital commented
Issue summary: View changes
FileSize
ultimate_cron-d10-compatibility-3290211-4.patch31.07 KB

The automated patch doesn't resolve everything, see below:

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      183  Call to deprecated method implementsHook() of class         
                    Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in 
                    drupal:9.4.0 and is removed from drupal:10.0.0. Use the     
                    hasImplementations() methods instead with the $modules      
                    argument.                                                   
--------------------------------------------------------------------------------

FILE: web/modules/contrib/ultimate_cron/tests/src/Functional/CronJobFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        116  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        117  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        118  Call to deprecated method assertNoFieldByXPath() of class   
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and assert that the result is empty.                        
--------------------------------------------------------------------------------
Fix now        130  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        138  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        139  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        140  Call to deprecated method assertNoFieldByXPath() of class   
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and assert that the result is empty.                        
--------------------------------------------------------------------------------
Fix now        149  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        179  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------
Fix now        180  Call to deprecated method assertFieldByXPath() of class     
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.3.0 and
                    is removed from drupal:10.0.0. Use $this->xpath() instead   
                    and check the values directly in the test.                  
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/ultimate_cron/tests/src/Kernel/UltimateCronQueueTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      28   Call to deprecated function module_load_install().          
                    Deprecated in drupal:9.4.0 and is removed from              
                    drupal:10.0.0. Use                                          
                    Drupal::moduleHandler()->loadInclude($module, 'install')    
                    instead. Note, the replacement no longer allows including   
                    code from uninstalled modules.                              
--------------------------------------------------------------------------------

I have manually fixed the reported issues and attached a patch here. The patch is working fine on both D9.4.x and D10-alpha6.

fathima.asmat’s picture

fathima.asmat CreditAttribution: fathima.asmat at CTI Digital commented
Issue tags: +Drupal 10 porting day
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
ultimate_cron-d10-compatibility-3290211-6.patch30.74 KB
ultimate_cron-d10-compatibility-3290211-6-interdiff.txt3.48 KB

Thanks for working on this. Don't forget to include an interdiff so it's easier to see what changes you made.

Fixed the logger and the time thing was fixed by #3256142: Deprecated function: Implicit conversion from float-string, the last one looks like it might have been a random fail.

Status: Needs review » Needs work

The last submitted patch, 6: ultimate_cron-d10-compatibility-3290211-6.patch, failed testing. View results

Berdir credited bruno.bicudo.

Berdir credited DieterHolvoet.

Berdir credited hmdnawaz.

Berdir credited skrug.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
ultimate_cron-d10-compatibility-3290211-13.patch31.58 KB
ultimate_cron-d10-compatibility-3290211-13-interdiff.txt4.75 KB

Tricky fails. The queue stuff is a new core test that can't work with our scheduling logic, so skipping.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
ultimate_cron-d10-compatibility-3290211-14.patch31.81 KB
ultimate_cron-d10-compatibility-3290211-14-interdiff.txt781 bytes

9.3 compatibility.

  • Berdir committed 1398154 on 8.x-2.x 
    Issue #3290211 by Berdir, Project Update Bot, fathima.asmat, bruno....
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Green, yay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips