In olivero/templates/views/views-mini-pager.html.twig the following string wrongly has “>{{ 'Previous page'|t }}” when it should be “>{{ 'Next page'|t }}”.
<li class="pager__item pager__item--control pager__item--next">
<a href="{{ items.next.href }}" class="pager__link" title="{{ 'Go to next page'|t }}" rel="next"{{ items.next.attributes|without('href', 'title', 'rel') }}>
<span class="visually-hidden">{{ 'Previous page'|t }}</span>
{% include "@olivero/../images/pager-previous.svg" %}
</a>
</li>
As a result, a screenreader will typically announce both “Previous page” and “Go to next page” to the user when focus is on this control.
I am also confused by “olivero/images/pager-previous.svg”, but there appears to be no “next.svg” file, so I am assuming that this is my lack of knowledge on these things.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3291317-5-nextpage.png | 119.03 KB | immaculatexavier |
#5 | 3291317-5.patch | 855 bytes | immaculatexavier |
#2 | __Olivero.png | 125.95 KB | mherchel |
Comments
Comment #2
mherchelConfirmed. Great catch! Attaching screenshot to the summary.
yeah, we just mirror the "previous" image by applying
transform: scalex(-1)
in the CSSComment #3
mherchelComment #4
mherchelComment #5
immaculatexavier CreditAttribution: immaculatexavier as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedAttaching the patch and screenshot- Now Views Mini Pager's next button labeled to Next Page.
Comment #6
longwaveThanks!
Comment #11
lauriiiCommitted eb2d361 and pushed to 10.1.x. Cherry-picked to 10.0.x, 9.5.x, and 9.4.x. Thanks!