Problem/Motivation

I started using a custom drupalci.yml to a) speed up test runs and run all tests together and temporarily enable deprecations to prepare for D10. In paragraphs, I noticed that search_api still has a jquery.once usage. However, it doesn't even seem to be used, so I'm just removing it.

Steps to reproduce

Proposed resolution

Remaining tasks

CommentFileSizeAuthor
#14 3292775-14--drupal_10_compatibility.patch65.16 KBdrunken monkey
#14 3292775-14--drupal_10_compatibility--with_drupalci_yml.patch65.61 KBdrunken monkey
#14 3292775-14--drupal_10_compatibility--interdiff.txt11.49 KBdrunken monkey
#12 search-api-d10-3292775-11.patch53.77 KBBerdir
#11 search-api-d10-3292775-11.txt53.77 KBBerdir
#11 search-api-jquery-once-with-deprecations-3292775-11-interdiff.txt1.76 KBBerdir
#11 search-api-jquery-once-with-deprecations-3292775-11.patch54.23 KBBerdir
#7 search-api-jquery-once-with-deprecations-3292775-6-interdiff.txt11.32 KBBerdir
#7 search-api-jquery-once-with-deprecations-3292775-6.patch53.15 KBBerdir
#5 search-api-jquery-once-with-deprecations-3292775-5.patch44.83 KBBerdir
#2 search-api-jquery-once-3292775-2.patch286 bytesBerdir
#2 search-api-jquery-once-with-deprecations-3292775-2.patch750 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
search-api-jquery-once-with-deprecations-3292775-2.patch750 bytes
search-api-jquery-once-3292775-2.patch286 bytes

Note: You want to commit this either without the drupalci.yml file or switch the suppress deprecation flag around to avoid for example D10 tests failing on new deprecations. Also, there might other modules being enabled that have deprecations, you can't separate that.

The last submitted patch, 2: search-api-jquery-once-with-deprecations-3292775-2.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Still quite a lot of deprecations, your own hooks can be ignored, will be impossible to commit with deprecations enabled then anyway. lots of setUp() with missing :void.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
search-api-jquery-once-with-deprecations-3292775-5.patch44.83 KB

Fixing render(), seUp() and drupal_get_path(), that should remove a lot of noise. the temporary database stuff is probably going to be painful.

Status: Needs review » Needs work

The last submitted patch, 5: search-api-jquery-once-with-deprecations-3292775-5.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
search-api-jquery-once-with-deprecations-3292775-6.patch53.15 KB
search-api-jquery-once-with-deprecations-3292775-6-interdiff.txt11.32 KB

fixed that syntax error and fixed most things in unit and kernel tests.

Status: Needs review » Needs work

The last submitted patch, 7: search-api-jquery-once-with-deprecations-3292775-6.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review

just a few deprecations left beside your own. I didn't update .info.yml yet, this requires at least Drupal 9.3

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Remove unused dependency of deprecated jquery.once » Drupal 10 compatibility
Status: Needs work » Needs review
FileSize
search-api-jquery-once-with-deprecations-3292775-11.patch54.23 KB
search-api-jquery-once-with-deprecations-3292775-11-interdiff.txt1.76 KB
search-api-d10-3292775-11.txt53.77 KB

Handful of extra fixes. Only remaining deprecations:

  8x: Connection::queryTemporary() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. There is no replacement. See https://www.drupal.org/node/3211781
    8x in BackendTest::testBackend from Drupal\Tests\search_api_db\Kernel

  8x: Connection::generateTemporaryTableName() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. There is no replacement. See https://www.drupal.org/node/3211781
    8x in BackendTest::testBackend from Drupal\Tests\search_api_db\Kernel

As mentioned, these are likely going to be very painful, as this gone without any replacement whatsoever. There's special prefix logic in there for sqlite.

Also, this:

  1x: Javascript Deprecation: The Modernizr touch events test is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0. See https://www.drupal.org/node/3277381 for information on its replacement and how it should be used.
    1x in AjaxTest::testAjax from Drupal\Tests\search_api\FunctionalJavascript

No idea about this. The test passes on D10, maybe a false positive.

All tests of the main module except LanguageWithFallbackTest which depends on a module that I don't have pass locally on D10.

Again a patch without drupalci.yml, that should be ready to commit.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
search-api-d10-3292775-11.patch53.77 KB

Wrong filename for the patch without drupalci.yml

The last submitted patch, 11: search-api-jquery-once-with-deprecations-3292775-11.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
3292775-14--drupal_10_compatibility--interdiff.txt11.49 KB
3292775-14--drupal_10_compatibility--with_drupalci_yml.patch65.61 KB
3292775-14--drupal_10_compatibility.patch65.16 KB

Thanks a lot, great job! And sorry for the long delay.

The attached also fixes the rest of the tours, other than that I would just commit this for now and leave the mess with temporary tables for another time.

The last submitted patch, 14: 3292775-14--drupal_10_compatibility--with_drupalci_yml.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Fixed

Tests pass, too, so looking good.
Committed.
Thanks a lot again!

Created #3300927: Remove usage of temporary tables from DB backend for the temporary table follow-up. And I guess we’ll just hope the JS one is a fluke, otherwise I have no idea what it means.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.