Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
\Drupal\Core\Composer\Composer::preAutoloadDump
contains this code block:
if ($repository->findPackage('symfony/http-kernel', $constraint)) {
$autoload['classmap'] = array_merge($autoload['classmap'], [
$vendor_dir . '/symfony/http-kernel/HttpKernel.php',
$vendor_dir . '/symfony/http-kernel/HttpKernelInterface.php',
$vendor_dir . '/symfony/http-kernel/TerminableInterface.php',
]);
}
if ($repository->findPackage('symfony/http-kernel', $constraint)) {
$autoload['classmap'] = array_merge($autoload['classmap'], [
$vendor_dir . '/symfony/http-kernel/HttpKernel.php',
$vendor_dir . '/symfony/http-kernel/HttpKernelInterface.php',
$vendor_dir . '/symfony/http-kernel/TerminableInterface.php',
]);
}
I think one time will be enough.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff_5-9.txt | 980 bytes | Spokje |
#9 | 3293051-9-10.0.x.10.1.x.patch | 995 bytes | Spokje |
| |||
#2 | 3293051-2-9.4.x.9.5.x.patch | 997 bytes | Spokje |
Comments
Comment #2
SpokjeComment #3
SpokjePostponing on the commit of #3076684: Remove deprecated vendor cleanup scripts after which we'll need a separate
10.0.x/10.1.x
patch.Comment #4
SpokjeComment #5
SpokjeComment #6
SpokjeComment #7
SpokjeComment #8
longwaveThe 10.x patch is removing the wrong thing:
symfony/http-kernel
is the duplicate block.Comment #9
SpokjeOuch, nasty. Great catch @longwave, that'll teach me not do a quick patch before ending the day...
Comment #10
arunkumarkComment #11
longwaveThanks - #2 and #9 are RTBC.
Comment #12
alexpottCommitted and pushed 6793e2ea36 to 10.1.x and b2f6bba562 to 10.0.x. Thanks!
Committed and pushed c90ec155ac to 9.5.x and 17fcbdbbb9 to 9.4.x. Thanks!
Duplicate code is a bug.