Problem/Motivation

In #3259024: Remove deprecated 'app.root' and 'site.path' services we removed the app.root and site.path services as they are now container parameters, but we failed to remove the actual classes themselves. \Drupal\Core\AppRootFactory and \Drupal\Core\SitePathFactory are now unused.

Steps to reproduce

Proposed resolution

Delete the unused classes.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3293431-2.patch1.83 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3293431-2.patch1.83 KB
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Reviewed & tested by the community

Makes sense in light of the services removed.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

  • catch committed 8438ad6 on 10.0.x 
    Issue #3293431 by longwave: Remove obsolete AppRootFactory and...
  • catch committed c3450dd on 10.1.x
    Issue #3293431 by longwave: Remove obsolete AppRootFactory and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.