Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Comment | File | Size | Author |
---|---|---|---|
#2 | tfa.1.x-dev.rector.patch | 6.33 KB | Project Update Bot |
|
Comments
Comment #2
Project Update Bot CreditAttribution: Project Update Bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedThe rector changes were only touching the automated tests which we only run in Drupal 9 anyway, and they still all pass. Committing these, and setting issue to active in case the bot runs again.
Comment #5
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedComment #6
Project Update Bot CreditAttribution: Project Update Bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #7
Kristen PolNeeds manual analysis to see what is remaining to get this to be Drupal 10 compatible. As @jcnventura said, the bot patch was only in the tests. We need to see what else, if anything, needs to be changed. Note there aren't any plans for more bot runs in the near future so human review would be good here.
Comment #8
mmjvb CreditAttribution: mmjvb as a volunteer commentedTwo issues remaining according to upgrade_status (us-a):
- getDefinition() of class Drupal\tfa\TfaValidationPluginManager deprecated and removed in 2.x
- Drupal\tfa\Form\TfaLoginForm extends @internal class Drupal\user\Form\UserLoginForm
Both of them seem out of scope of D10 compatibility, should not block claiming to be compatible for both modules.
Comment #9
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedYeah, that getDefinition() is a bit old. That entire class got deprecated in the meantime. I'll have to revisit the classes I removed between 1.x and 2.x and mark them as deprecated.
But there will never be a Drupal 10 version of the 1.x branch. There is an upgrade path, and it is simply impossible to provide support for D8 and D10 with the same code. So, the current code will support D8 and D9, and the new even more heavily refactored branch will support D9 and D10 (and already does).
Comment #10
mmjvb CreditAttribution: mmjvb as a volunteer commentedJust ran against dev and only internal class error remains. Not supporting D10 yet, though.
You might have a look at drupal-check (84 errors) as well
Comment #11
Kristen PolWorking during porting day.
@jcnventura Do you need any help on this? Since you moved to Active, I assume not, but it's not 100% clear to me given the last few comments. Thanks.
Comment #12
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedRemoving the tag. The main issue with D10 support for TFA module is the lack of D10 support in encrypt and real_aes. Once those land, D10 support will be added to this module.
Comment #14
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedMarked the module as supporting D10, now that real_aes and encrypt have D10 versions.
Comment #15
Kristen PolYay! Thanks 🙏