Problem/Motivation

Deprecations are by design a moving target, drupal core keeps adding new deprecations as it develops, not having any deprecations means you can only support the most recent (possibly still in-development) core branch. Also, your tests keep breaking on their own. Even right now, there might already be deprecations when testing on D10 for D11.

Therefore, I recommend to not have tests fail on deprecations. Instead, flip the switch/add drupalci.yml only temporarily as a patch when adding compatibility for a new major core version or just run test against the new version (enabling deprecations is helpful to catch some non-obvious deprecations as you often get more helpful errors and can do that if your test dependencies aren't compatible yet).

Steps to reproduce

Proposed resolution

Remove drupalci.yml. Alternatively, switch the suppress deprecations flag if using an optimized configuration, but simplenews doesn't have that it seems.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

  • Berdir committed 6e0c2db on 8.x-2.x
    Issue #3301466 by Berdir: Remove drupalci.yml
    

  • Berdir committed 1042207 on 3.x
    Issue #3301466 by Berdir: Remove drupalci.yml
    
Berdir’s picture

Status: Active » Fixed

Per #3254683: Timeout message contains invalid placeholder !cron_throttle_setting, apparently you can't test this as a patch, so I just went ahead and removed it in 3.x and 8.x-2.x.

Berdir credited TR.

Berdir’s picture

Berdir’s picture

Weird, even committing that didn't seem to have worked. I'm restoring it and explicitly suppressing deprecations instead. Lets try that as a patch first.

Berdir’s picture

  • Berdir committed e3f2e54 on 3.x
    Issue #3301466 by Berdir: Restore drupalci.yml and explicitly suppress...

  • Berdir committed 4e72e67 on 8.x-2.x
    Issue #3301466 by Berdir: Restore drupalci.yml and explicitly suppress...
Berdir’s picture

Status: Needs review » Fixed

Ok, that's better.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

AdamPS’s picture

Status: Closed (fixed) » Active

The disadvantage of this is that apparently some D10 deprecations were never fixed.

https://www.drupal.org/node/3159568 occurs and when using D10 the warning has gone again, without any sign that the code is still "wrong". Let's remove drupalci.yml again at least temporarily to see what else it might reveal.

  • AdamPS committed d7fc4e8c on 4.x
    git commit -m 'Issue #3301466 by AdamPS: Re-enable deprecations...
AdamPS’s picture

Title: Suppress deprecations/Remove drupalci.yml » Suppress deprecations
Version: 3.x-dev » 4.x-dev

  • AdamPS committed 36f3326a on 4.x
    Issue #3301466 by AdamPS: Suppress deprecations
    
AdamPS’s picture

Ha - now I have a similar problem trying to make the deprecations come back again!

AdamPS’s picture

Status: Active » Needs review
FileSize
1.62 KB

  • AdamPS committed eaf91f0c on 4.x
    Issue #3301466 by AdamPS: Fix deprecations
    
AdamPS’s picture

Title: Suppress deprecations » Fix D10 deprecations
Status: Needs review » Fixed

With #18 and after fixing #3349310: PHP 8.2 compatibility the tests seem to be working even with deprecations enabled. So perhaps we can leave the deprecations enabled for now? Or I guess we can disable again, then re-enable when testing D11 support??

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.