Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
When we removed the RDF module from the Standard profile in #3243121: Remove RDF module from the Standard profile we overlooked \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest.
In that test there is a comment stating This is a list of modules that are enabled in the 'standard' profile..
Since we removed RDF from Standard, it shouldn't be in that array.
Steps to reproduce
Proposed resolution
Remove 'rdf' from \Drupal\Tests\system\Functional\Common\NoJavaScriptAnonymousTest::$modules
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3303453-2.patch | 553 bytes | Spokje |
| |||
Comments
Comment #2
SpokjeComment #3
SpokjeComment #4
catchExtremely does what it says on the tin issue.
RTBC-ing this and will also commit it in the next day or so, on the assumption that there's no much can go wrong with this six character patch.
Comment #5
longwaveWonder if we can refactor that test so it reads the list of modules from Standard, instead of having to maintain two lists.
Comment #6
catchI kind of think with that test we could enable every available module (bit like install/uninstall test), and then if we really have to exclude one because it loads of JavaScript for anonymous users, special case it.
Comment #7
quietone CreditAttribution: quietone at PreviousNext commentedComment #9
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!
Tagging needs follow-up for the anon no JavaScript test refactoring.
Comment #11
SpokjeOpened #3306713: Refactor module array in NoJavaScriptAnonymousTest as a follow-up.