Problem/Motivation

At #3291700: new subtree split of core Quick Edit into contrib (v2) we nearly got the 10.0.x tests passing, but there's at least 1 remaining test fail regarding ie11.

Steps to reproduce

Proposed resolution

Probably just remove the test, since we've dropped support for ie11.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork quickedit-3304020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww created an issue. See original summary.

dww opened merge request !10

dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented
Status: Active » Needs review

I keep forgetting to queue with PHP 8.1 for D10. 😅

Anyway, here's one approach.

The other way would be to just remove the assertion entirely and not care about IE at all.

Also, curious if this works on 9.4.x and if we actually need to do #3303241: Bump core requirement to ^9.4 || ^10 or not.

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala as a volunteer and at SWIS commented

Probably the most future proof to remove the assertion. This will come back at some point since it the alert will be removed then.

dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented

Bot's happy that way, too (as expected). RTBC? Thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

IE11 is dead, removing the code entirely seems like the best solution.

dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented

Cool, makes sense. Saving credits for the commit message. Thanks!

  • dww committed c32b5ff on 1.0.x 
    Issue #3304020 by dww, bbrala, longwave: Tests failing on 10.0.x
dww’s picture

dww
we/he/they
CreditAttribution: dww at TEN7 commented
Status: Reviewed & tested by the community » Fixed

Merged! 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.