Remove Bartik from Drupal core

First pass, did not regenerate the dictionary yet. Will conflict with the Seven removal patch in a few places, but that's to be expected.

While grepping for Bartik I found a bunch of out of date docs and opened #3304650: Theme stylesheet documentation is out of date

Adding parent, remaining tasks and change record etc

I don't expect any migration tests needs changes and I see that the failing test is not a migration tests, so removing that from remaining tasks.

Nothing found in the @todo.

$ grep -riI -A2 --exclude-dir="bartik" @todo core | grep -i bartik
$ 

Looking through this, I searched the codebase for "bartik"

I found a number of things that could be removed (not sure if these are in scope).

• Reference to "themes/bartik/color/preview.html", in core/.cspell.json
• Reference to bartik in comment in core/lib/Drupal/Core/Asset/AssetResolverInterface.php
• Reference to bartik in a comment in core/lib/Drupal/Core/Extension/ThemeHandlerInterface.php
• Reference to bartik in a comment in the RDF module test at core/modules/rdf/tests/src/Functional/StandardProfileTest.php.
• There's a number of references to Bartik in the migration tests. I'm guessing that many of these are valid, because people will be migrating from Bartik to Olivero.

Not sure all of these are valid, but I think some may be.

Good point to search for bartik, so I checked as well.

First for migrate related.

$ grep -ri bartik --exclude-dir="bartik" core | awk -F: '{print $1}' | grep -ie migrat -e drupal7.php | sort -u | nl
     1  core/modules/block/migrations/d7_block.yml
     2  core/modules/block/tests/src/Kernel/Migrate/d7/MigrateBlockContentTranslationTest.php
     3  core/modules/block/tests/src/Kernel/Migrate/d7/MigrateBlockTest.php
     4  core/modules/block/tests/src/Kernel/Plugin/migrate/source/d7/BlockTranslationTest.php
     5  core/modules/block/tests/src/Unit/Plugin/migrate/process/BlockRegionTest.php
     6  core/modules/color/tests/fixtures/drupal7.php
     7  core/modules/color/tests/src/Kernel/Migrate/d7/MigrateColorTest.php
     8  core/modules/color/tests/src/Kernel/Plugin/migrate/source/d7/ColorTest.php
     9  core/modules/migrate_drupal/tests/fixtures/drupal7.php
    10  core/modules/rdf/tests/fixtures/drupal7.php
    11  core/modules/system/migrations/d7_theme_settings.yml
    12  core/modules/tracker/tests/fixtures/drupal7.php

@mherchel is right, the references to bartik are valid. MigrateColorTest does depend on Bartik being installed but the plan is to remove Color first, then Bartik.

Then for not migrate related

$ grep -ri bartik --exclude-dir="bartik" core | awk -F: '{print $1}' | grep -iv migrat | grep -iv drupal7.php | sort -u | nl
     1  core/.cspell.json
     2  core/lib/Drupal/Core/Asset/AssetResolverInterface.php
     3  core/lib/Drupal/Core/Config/ConfigInstallerInterface.php
     4  core/lib/Drupal/Core/Extension/InfoParserInterface.php
     5  core/lib/Drupal/Core/Extension/ThemeHandlerInterface.php
     6  core/lib/Drupal/Core/Plugin/plugin.api.php
     7  core/lib/Drupal/Core/Theme/AjaxBasePageNegotiator.php
     8  core/lib/Drupal/Core/Theme/Registry.php
     9  core/MAINTAINERS.txt
    10  core/misc/cspell/dictionary.txt
    11  core/modules/breakpoint/src/BreakpointManager.php
    12  core/modules/comment/tests/src/Functional/CommentLinksTest.php
    13  core/modules/contextual/contextual.module
    14  core/modules/help/help.api.php
    15  core/modules/rdf/tests/src/Functional/StandardProfileTest.php
    16  core/tests/Drupal/KernelTests/Core/Theme/ConfirmClassyCopiesTest.php
    17  core/tests/Drupal/Tests/WebAssert.php
    18  core/themes/classy/classy.theme

I've made a note to add more thorough searching to the steps to remove a module/theme.

The cspell config needs updating, and the dictionary regenerating.

Reference to bartik in comment in core/lib/Drupal/Core/Asset/AssetResolverInterface.php
Reference to bartik in a comment in core/lib/Drupal/Core/Extension/ThemeHandlerInterface.php

Opened #3304650: Theme stylesheet documentation is out of date for this as the problem is wider than just renaming something.

Reference to bartik in a comment in the RDF module test at core/modules/rdf/tests/src/Functional/StandardProfileTest.php.

RDF is also on its way out so I left this alone, but we can fix it here I guess.

Re-ran the recursive grep from #10 (thanks @quietone for posting that!) with the MR branch checked out, and still had:

     1	core/lib/Drupal/Core/Asset/AssetResolverInterface.php
     2	core/lib/Drupal/Core/Extension/ThemeHandlerInterface.php
     3	core/misc/cspell/dictionary.txt

So I pushed a commit to fix 1 + 2. 😅

Also fixed the file hash in ClassyPreprocessUnchangedTest now that classy.theme has changed (only to remove 'bartik' from some comments). Fixed that assertSame() to put the expected value as the 1st param, while I was at it.

The other test fails don't make much immediate sense, but I don't really have time to investigate now. Maybe random fails? Let's see. 🤞

Yeah, passes locally:

% ./vendor/bin/phpunit -c core/phpunit.xml core/modules/book/tests/src/Functional/BookTest.php
PHPUnit 9.5.21 #StandWithUkraine

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing Drupal\Tests\book\Functional\BookTest
................                                                  16 / 16 (100%)

Time: 02:33.625, Memory: 10.00 MB

OK (16 tests, 749 assertions)

Let's hope the bot agrees on this run.😅

Yay. So only the release note and the cspell directory regeneration are needed.

Back to NR to get more eyes on this in case anyone spots something else.

Thanks,
-Derek

Yay, one more extension removed!

Let's see if I can do the reroll/rebase

Rerolled, left comment on the only open thread in GitLab.

Confirmed that all of the changes to existing code makes sense. 👍 I was surprised how many references there were still pointing to Bartik 😅 Also confirmed that all of the remaining references to Bartik are related to migration. 👍

Does this need a change record given that we already published https://www.drupal.org/node/3304352? 🤔

Prepared issue credits for another committer ✌️

Forgot to mention that I also tested manually installing Drupal without Bartik and all worked as expected 👍

Added a CR specific for the deprecation, so the branch/version information is correct, and published it.
wrong issue

Closed #3259925: Use Olivero instead of Bartik as example theme in documentation as a duplicate and moved over credit.