Problem/Motivation

Make sure we use the latest version of Bootstrap to ensure it's PHP8 compatibility.

Proposed resolution

https://www.drupal.org/project/bootstrap/releases/8.x-3.25

"require": {
        "drupal/bootstrap": "^3"
    },
CommentFileSizeAuthor
#3 3305080-update-drupalbootstrap-to.patch327 bytesMikell

Issue fork socialbase-3305080

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mikell created an issue. See original summary.

Mikell’s picture

Mikell CreditAttribution: Mikell at Dropsolid commented
Issue summary: View changes
Mikell’s picture

Mikell CreditAttribution: Mikell at Dropsolid commented
FileSize
3305080-update-drupalbootstrap-to.patch327 bytes

Mikell opened merge request !144

Mikell opened merge request !145

Mikell’s picture

Mikell CreditAttribution: Mikell at Dropsolid commented
Status: Needs work » Needs review
Mikell’s picture

Mikell CreditAttribution: Mikell at Dropsolid commented

Used a patch on bootstrap 8.23 to make it php 8 compatibility

Mikell’s picture

Mikell CreditAttribution: Mikell at Dropsolid commented
Status: Needs review » Closed (works as designed)
navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at Open Social commented
Status: Closed (works as designed) » Active

Thanks @Mikell for this, I will takeover from here ;-)

navneet0693 closed merge request !144

navneet0693 closed merge request !145

navneet0693 opened merge request !147

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at Open Social commented
Status: Active » Needs review

New merge request: https://git.drupalcode.org/project/socialbase/-/merge_requests/147

I have removed the patch as the issue for the patch was fixed. See: https://www.drupal.org/project/bootstrap/issues/3209773

  • navneet0693 committed e618996 on 2.4.x 
    Issue #3305080 by Mikell, navneet0693: Update drupal/bootstrap to 3.25...
navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at Open Social commented
Version: 2.3.0 » 2.4.x-dev
navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at Open Social commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.