Problem/Motivation

Create scenarios for reading an Elastic IP for AWS
Feature file: AWS-ATDD-03-01-OperateElasticIPs.feature

Issue fork cloud-3309124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TamakiFujino created an issue. See original summary.

TamakiFujino opened merge request !1295

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Active » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for your providing this patch. Can you check my comment?

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for your providing the patch. Can you check my comment? Other than that, this looks fine.

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Thanks!

yas made their first commit to this issue’s fork.

  • yas committed 8545a05 on 5.x authored by TamakiFujino 
    Issue #3309124 by TamakiFujino, yas, kumikoono: Add a BDD test scenario...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@kumikoono

Thank you for your review.

@tamakifujino

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 74aaaaf on 4.x 
    Issue #3309124 by TamakiFujino, yas, kumikoono: Add a BDD test scenario...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.