Problem/Motivation

  • Create scenarios for reading and updating a snapshot for AWS
  • Feature file: AWS-ATDD-04-01-OperateSnapshots.feature
  • The filtering tag should include only @ci_job.

Issue fork cloud-3310560

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TamakiFujino created an issue. See original summary.

TamakiFujino opened merge request !1321

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Active » Needs review
TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for your patch. Can you add more comments into the lines before commenting out?

Other than that, this patch looks fine.

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review

@kumikoono Sorry I missed your comments regarding the comment before. I updated and added the lines.

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs review » Needs work
TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review

Removed the parameter "snapshot_description" since the parameter "description" was already set.

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs review » Needs work
TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@kumikoono

Thank you for your review.

@tamakifujino

I'll m
Thank you for adding the scenarios. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

@tamakifujino

Can you please rebase the patch? Thanks!

TamakiFujino’s picture

TamakiFujino CreditAttribution: TamakiFujino commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@tamakifujino

Thank you for rebasing the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 6d60eea on 5.x authored by TamakiFujino 
    Issue #3310560 by TamakiFujino, yas, kumikoono: Add a BDD test scenario...

  • yas committed 2accf35 on 4.x 
    Issue #3310560 by TamakiFujino, yas, kumikoono: Add a BDD test scenario...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.