Problem/Motivation

  • Include a VPC name along with a VPC ID at the detailed view of AWS Cloud Internet Gateway.

Issue fork cloud-3312622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1346

sekinet’s picture

sekinet CreditAttribution: sekinet commented
Status: Active » Needs review

@yas @kumikoono

Could you please review the patch?

yas made their first commit to this issue’s fork.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented

The change in the Internet Gateway looks good to me.
I'll let you know if the BDD testing is ok.

sekinet’s picture

sekinet CreditAttribution: sekinet commented

@kumikoono

Thank you for checking. I have included the fix for the List column name in the patch. Could you please check again?

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for your update. This looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@kumikoono

Thank you for your review.

@sekinet

Thank you for the patch. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Include a VPC name along with a VPC ID at the detailed view of AWS Cloud Internet Gateway » Set a VPC name along with a VPC ID at the detailed view of AWS Cloud Internet Gateway

  • yas committed ebf301e on 5.x authored by sekinet 
    Issue #3312622 by sekinet, yas, kumikoono: Set a VPC name along with a...

  • yas committed def9015 on 4.x 
    Issue #3312622 by sekinet, yas, kumikoono: Set a VPC name along with a...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.