In #3239120: Consumer endpoint incorrectly includes the language prefix the language prefix was removed the generated consumer endpoint, but this was only fixed in the saml_sp__get_settings() function.

This leads to an inconsistency with the URL in e.g. the metadata, which still contains the language prefix.

Issue fork saml_sp-3316762

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matthijs created an issue. See original summary.

Matthijs’s picture

Matthijs
Primary language Dutch
CreditAttribution: Matthijs at Dropsolid commented
Issue summary: View changes

Matthijs opened merge request !25

Matthijs’s picture

Matthijs
Primary language Dutch
CreditAttribution: Matthijs at Dropsolid commented
Status: Active » Needs review

  • jrglasgow committed 11d564a on 4.x authored by Matthijs 
    Issue #3316762 by Matthijs: Metadata incorrectly includes the language...
jrglasgow’s picture

jrglasgow CreditAttribution: jrglasgow commented
Status: Needs review » Fixed

@Matthijs,
Thanks for catching this. Unfortunately I don't work on any sites using translations/internationalization so I never see this issue.

Matthijs’s picture

Matthijs
Primary language Dutch
CreditAttribution: Matthijs at Dropsolid commented
Status: Fixed » Needs work

I just noticed my patch is causing issues when using the path_alias module. Will create a new MR to fix this.

Matthijs opened merge request !26

Matthijs’s picture

Matthijs
Primary language Dutch
CreditAttribution: Matthijs at Dropsolid commented
Status: Needs work » Needs review

jproctor’s picture

jproctor
they/them
Primary language English
CreditAttribution: jproctor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.