Problem/Motivation

The ID attribute would be very useful to build SPAs or just to link to a specific section of the page.

Proposed resolution

Add the ID attribute to the settings of all the rocketship layouts.

Remaining tasks

- Patch
- Review
- Test

User interface changes

The configuration forms of the rocketship sections now have the option to set the id attribute

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 rocketship_core-3319398-2.patch2.33 KBakalam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalam created an issue. See original summary.

akalam’s picture

akalam CreditAttribution: akalam at Dropsolid commented
Status: Active » Needs review
FileSize
rocketship_core-3319398-2.patch2.33 KB

I'm adding the id attribute here as a patch instead of a MR because the Drupal infra is experimenting delays and the fork is not available yet. Moving to "Needs review".

nginex’s picture

nginex CreditAttribution: nginex as a volunteer and at Dropsolid for Dropsolid commented
Assigned: Unassigned » nginex

  • d9061cb committed on 6.x 
    Issue #3319398 by akalam: Allow setting the id attribute on the...
nginex’s picture

nginex CreditAttribution: nginex as a volunteer and at Dropsolid for Dropsolid commented
Assigned: nginex » Unassigned
Status: Needs review » Fixed

Thanks for the patch. I adjusted a bit code to avoid empty id attribute.

akalam’s picture

akalam CreditAttribution: akalam at Dropsolid commented
Issue summary: View changes

Thanks to you for reviewing and for the fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.