Problem/Motivation

The following CSS hack applies to IE11 only:

_:-ms-fullscreen,
.fieldset {
  display: table;
  box-sizing: border-box;
  width: 100%;
}

We no longer support IE11 so we can remove this rule.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 Screenshot 2022-11-15 at 4.43.07 PM.png228.48 KBpradipmodh13
#2 3321004-2.patch1.12 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3321004-2.patch1.12 KB
pradipmodh13’s picture

pradipmodh13 CreditAttribution: pradipmodh13 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
Screenshot 2022-11-15 at 4.43.07 PM.png228.48 KB

Applied #2 patch. IE11 code has been successfully removed.
For ref attached screenshot.
Thank you @longwave

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Removed CSS is indeed IE11 only, and since 10.x upwards doesn't support IE11 any more, this can be removed.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3321004-2.patch, failed testing. View results

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Random fail due to #3041318: Various random fails due to mis-triggered Mink deprecation error. Started a retest and put it back on RTBC.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented

Still random failure. Code looks good. Re-queued tests.

  • catch committed 1e3ce67 on 10.1.x 
    Issue #3321004 by longwave: Remove IE11 hack from fieldset.css
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 1e3ce67 and pushed to 10.1.x. Thanks!

  • catch committed 9dd6583 on 10.0.x 
    Issue #3321004 by longwave: Remove IE11 hack from fieldset.css

(cherry...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Also backported to 10.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.