Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
Moving the submodule "image_captcha" from "captcha/image_captcha" to "captcha/modules/image_captcha" leads to a lot of problems for already existing captcha installations.
Steps to reproduce
Proposed resolution
I suggest we move the submodule folder back to its original spot, even if this isn't Drupal Best Practice.
We could also tag the 2.x release with a "Breaking Change" tag, but I think this isn't necessarily the best approach here.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork captcha-3321861
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
AnybodyJust added a MR for 2.x which might allow that change without breaking things.
Eventually we'll have to add a cache clear for the moved module!
BTW I just saw the _test modules in the modules directory. Is that correct? Or do these belong somewhere else (in tests...?)
Comment #5
Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented@Anybody, thanks for the heads-up! The location for the test modules is definitly incorrect! Test modules should always reside in "my_module/tests/modules/my_module_test"
Comment #6
Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented@Anybody, also thanks for the MR! I will test it soon! If this works, that would be definitely the best approach!
Comment #7
Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commentedUpdate hook works great! Added NULL checks and a further tiny update hook.
Please review!
Comment #8
AnybodyLGTM! All fine
Comment #9
Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commentedPerfect, all tests pass, pushing this to dev!