upgrade Symfony dependencies to RC1 [#3323741]

Problem/Motivation

https://github.com/symfony/symfony/releases/tag/v6.2.0-RC1

Steps to reproduce

COMPOSER_ROOT_VERSION=10.1.x-dev composer update symfony/* -W

Proposed resolution

$ ~/.composer/vendor/bin/composer-lock-diff --no-links
+------------------------------+--------------+------------+
| Production Changes           | From         | To         |
+------------------------------+--------------+------------+
| symfony/console              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/dependency-injection | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/error-handler        | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/event-dispatcher     | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/http-foundation      | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/http-kernel          | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/mime                 | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/process              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/routing              | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/serializer           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/validator            | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/var-dumper           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/var-exporter         | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/yaml                 | v6.2.0-BETA3 | v6.2.0-RC1 |
+------------------------------+--------------+------------+

+------------------------+--------------+------------+
| Dev Changes            | From         | To         |
+------------------------+--------------+------------+
| symfony/browser-kit    | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/css-selector   | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/dom-crawler    | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/filesystem     | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/finder         | v6.2.0-BETA1 | v6.2.0-RC1 |
| symfony/lock           | v6.2.0-BETA3 | v6.2.0-RC1 |
| symfony/phpunit-bridge | v6.2.0-BETA3 | v6.2.0-RC1 |
+------------------------+--------------+------------+

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#20	3323741-10.1-20.patch	37.49 KB	andypost
#20	10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass
#20	3323741-10.0-20.patch	37.49 KB	andypost
#20	10.0.x: PHP 8.1 & MySQL 5.7 28,389 pass
#20	interdiff.txt	2.14 KB	andypost
#19	3323741-10.1-19.patch	36.13 KB	andypost
#19	10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass
#19	3323741-10.0-19.patch	36.13 KB	andypost
#19	10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail
#19	interdiff.txt	818 bytes	andypost
#17	3323741-10.1-17.patch	35.33 KB	andypost
#17	10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass
#17	interdiff.txt	1.3 KB	andypost
#16	3323741-d10.0.x-15.patch	35.33 KB	Spokje
#16	10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail
#13	interdiff.txt	460 bytes	andypost
#12	3323741-12-10.0.patch	35.17 KB	andypost
#12	10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail
#8	3323741-7.patch	35.17 KB	Spokje
#8	10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass
#7	interdiff.2-7.txt	9.49 KB	Spokje
#7	interdiff.2-7.txt	9.49 KB	Spokje
#5	3323741-5.patch	35.4 KB	Spokje
#5	10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed
#5	interdiff.2-5.txt	9.66 KB	Spokje
#2	3323741-2.patch	24.69 KB	andypost
#2	10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail 10.1.x: PHP 8.2 & MySQL 8 28,478 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 November 2022 at 11:35

andypost created an issue. See original summary.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 11:36

Status:

Active

» Needs review

File	Size
3323741-2.patch	24.69 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail 10.1.x: PHP 8.2 & MySQL 8 28,478 pass, 1 fail

File

Size

3323741-2.patch

24.69 KB

10.0.x:
PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail

10.1.x:
PHP 8.2 & MySQL 8 28,478 pass, 1 fail

Comment #3

25 November 2022 at 12:42

Status:

Needs review

» Needs work

The last submitted patch, 2: 3323741-2.patch, failed testing. View results

Comment #4

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 25 November 2022 at 13:11

Status:

Needs work

» Needs review

File	Size
3323741-interdiff.txt	1.13 KB
3323741-4.patch	25.82 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail

Comment #5

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 25 November 2022 at 13:38

File	Size
interdiff.2-5.txt	9.66 KB
3323741-5.patch	35.4 KB
10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

File

Size

interdiff.2-5.txt

9.66 KB

3323741-5.patch

35.4 KB

10.0.x:
PHP 8.1 & MySQL 5.7 Patch Failed to Apply

10.1.x:
PHP 8.1 & MySQL 5.7 Custom Commands Failed

3 files were hidden/shown/deleted

File	Size
3323741-interdiff.txt	1.13 KB
3323741-4.patch	25.82 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail
3323741-2.patch	24.69 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail 10.1.x: PHP 8.2 & MySQL 8 28,478 pass, 1 fail

Comment #6

25 November 2022 at 14:20

The last submitted patch, , failed testing. View results

Comment #7

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 25 November 2022 at 14:37

File	Size
interdiff.2-7.txt	9.49 KB
interdiff.2-7.txt	9.49 KB

2 files were hidden/shown/deleted

File	Size
interdiff.2-5.txt	9.66 KB
3323741-5.patch	35.4 KB
10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 Custom Commands Failed

File

Size

interdiff.2-5.txt

9.66 KB

3323741-5.patch

35.4 KB

10.0.x:
PHP 8.1 & MySQL 5.7 Patch Failed to Apply

10.1.x:
PHP 8.1 & MySQL 5.7 Custom Commands Failed

Comment #8

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 25 November 2022 at 14:38

File	Size
3323741-7.patch	35.17 KB
10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass

File

Size

3323741-7.patch

35.17 KB

10.0.x:
PHP 8.1 & MySQL 5.7 Patch Failed to Apply

1 file was hidden/shown/deleted

File	Size
interdiff.2-7.txt	9.49 KB

Comment #9

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 15:03

+++ b/core/phpstan.neon.dist
@@ -5,7 +5,7 @@ includes:
-  level: 1
+  level: 2

that's unrelated change

Comment #10

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 25 November 2022 at 15:51

that's unrelated change

Yes sorry, didn't clear my workspace switching issues.
Removed it in patch #8.

Comment #11

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 25 November 2022 at 15:57

+++ b/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
@@ -32,7 +32,7 @@ class ComposerProjectTemplatesTest extends ComposerBuildTestBase {
    */
-  protected const MINIMUM_STABILITY = 'beta';
+  protected const MINIMUM_STABILITY = 'RC';

This is what I missed in #4...

Looks like we need a 10.0.x-specific version but otherwise all looks good.

Comment #12

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 16:17

File	Size
3323741-12-10.0.patch	35.17 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail

here's as 10.0 has no mck89/peast

Comment #13

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 16:18

File	Size
interdiff.txt	460 bytes

the only change is hash

Comment #14

25 November 2022 at 17:25

Status:

Needs review

» Needs work

The last submitted patch, 12: 3323741-12-10.0.patch, failed testing. View results

Comment #15

longwave

he/him

English

CreditAttribution: longwave at Full Fat Things commented 25 November 2022 at 18:09

+++ b/composer.lock
@@ -471,18 +471,18 @@
                 "symfony/console": "^6.2@beta",

symfony/console is still beta.

Comment #16

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 25 November 2022 at 18:11

File	Size
3323741-d10.0.x-15.patch	35.33 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail

Comment #17

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 18:42

Status:

Needs work

» Needs review

File	Size
interdiff.txt	1.3 KB
3323741-10.1-17.patch	35.33 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass

4 files were hidden/shown/deleted

File	Size
interdiff.2-7.txt	9.49 KB
3323741-7.patch	35.17 KB
10.0.x: PHP 8.1 & MySQL 5.7 Patch Failed to Apply 10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass
3323741-12-10.0.patch	35.17 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail
interdiff.txt	460 bytes

patch #8 missing console upgrade as well

Comment #18

25 November 2022 at 19:16

The last submitted patch, 16: 3323741-d10.0.x-15.patch, failed testing. View results

Comment #19

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 23:09

File	Size
interdiff.txt	818 bytes
3323741-10.0-19.patch	36.13 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail
3323741-10.1-19.patch	36.13 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass

3 files were hidden/shown/deleted

File	Size
3323741-d10.0.x-15.patch	35.33 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail PHP 8.2 & MySQL 8 28,385 pass, 1 fail
interdiff.txt	1.3 KB
3323741-10.1-17.patch	35.33 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass

Last missing hunk

Comment #20

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 November 2022 at 23:18

File	Size
interdiff.txt	2.14 KB
3323741-10.0-20.patch	37.49 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,389 pass
3323741-10.1-20.patch	37.49 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass PHP 8.2 & MySQL 8 28,482 pass

2 files were hidden/shown/deleted

File	Size
3323741-10.0-19.patch	36.13 KB
10.0.x: PHP 8.1 & MySQL 5.7 28,385 pass, 1 fail
3323741-10.1-19.patch	36.13 KB
10.1.x: PHP 8.1 & MySQL 5.7 28,482 pass

and another one from #3319794: Update to Symfony 6.2 RC or update drupal/recommended-project creation and testMinimumStabilityStrictness() to allow minimum-stability to be less stable than core's stability

Comment #21

26 November 2022 at 00:16

The last submitted patch, 19: 3323741-10.0-19.patch, failed testing. View results

Comment #22

26 November 2022 at 00:28

Status:

Needs review

» Needs work

The last submitted patch, 20: 3323741-10.1-20.patch, failed testing. View results

Comment #23

Spokje

Dutch

CreditAttribution: Spokje as a volunteer commented 26 November 2022 at 07:23

Status:

Needs work

» Needs review

Comment #24

longwave

he/him

English

CreditAttribution: longwave at Full Fat Things commented 28 November 2022 at 09:29

Status:

Needs review

» Reviewed & tested by the community

The Symfony updates all look correct to me and the temporary project stability changes from #3319794: Update to Symfony 6.2 RC or update drupal/recommended-project creation and testMinimumStabilityStrictness() to allow minimum-stability to be less stable than core's stability have been reverted, the tests pass so this is RTBC.

Comment #25

28 November 2022 at 10:12

catch committed 24a3203 on 10.0.x

Issue #3323741 by andypost, Spokje, catch, longwave: upgrade Symfony...

catch committed 7fa1fe8 on 10.1.x

Issue #3323741 by andypost, Spokje, catch, longwave: upgrade Symfony...

Comment #26

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 28 November 2022 at 10:12

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Comment #27

12 December 2022 at 10:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

upgrade Symfony dependencies to RC1

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Parent issue

Related issues