Problem/Motivation
Based on #3323977: Drupal 10 only: Drush support it seems we should make a semantic versioned 2.x that only supports Drupal 10.
I propose keeping support for the 8.x-1.x branch for as long as Drupal 9 is supported and as long as folks are interested in maintaining it.
We should document clearly on the project page when to use which branch.
Remaining tasks
* Adjust info file to specify 8.x is Drupal 9 only and 2.x is Drupal 10 only
* Proposed documentation for the project pge
* Agreement among maintainers on this proposal
Issue fork stage_file_proxy-3323978
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
smustgrave CreditAttribution: smustgrave at Mobomo commentedSounds like we will have to revert the D10 work from the 8.x-1.x branch also.
Comment #3
gregglesDoes the work so far make it D10 only or does it work ok on D9?
Comment #4
smustgrave CreditAttribution: smustgrave at Mobomo commentedAccording to #3323977: Drupal 10 only: Drush support it's saying 10 isn't working and the change can't be made in 9. (haven't checked)
But if that's the case we should revert back 8.x-1.x to D9 only and make 2.0.x D10 only.
Thoughts?
Comment #5
gregglesCan you list out the things that need to be reverted?
Comment #6
smustgrave CreditAttribution: smustgrave at Mobomo commentedReviewing https://git.drupalcode.org/project/stage_file_proxy/-/commit/c939229
We may be able to just remove the change in the .info
Comment #7
gregglesOK, got it. Thanks!
Adjusting the issue summary to match that situation.
Does this proposal make sense to you?
Comment #8
smustgrave CreditAttribution: smustgrave at Mobomo commentedYup will try and work on this tomororw.
Comment #10
smustgrave CreditAttribution: smustgrave at Mobomo commentedTake a look at the MR
Should revert 8.x-1.x. to D9 only
Pushed https://git.drupalcode.org/project/stage_file_proxy/-/tree/2.0.x up too which is for D10.
Once this RTBC will merge in https://www.drupal.org/project/stage_file_proxy/issues/3323977
Do a 2.0.0 release and 8.x-1.5 release
and update project page.
Comment #11
gregglesThe test fail is on Drupal 10 which...makes sense :)
I adjusted the config so the 8.x-1.x branch no longer has a Drupal 10 test run for it. We should add that test to the 2.0.x branch when a release exists.
MR looks good to me. Thanks!
Comment #13
smustgrave CreditAttribution: smustgrave at Mobomo commentedComment #14
smustgrave CreditAttribution: smustgrave at Mobomo commentedAll done!
Comment #15
mglamanThis prevents folks from upgrading to D10 without uninstalling stage_file_proxy, since there is no bridge from 9 -> 10. 1.5 is strictly D9 and 2.0.0 is strictly D10.
Comment #16
gregglesFollowup for #15 is in #3325366: Add support for D9 on 2.0.x branch.
Comment #17
nomisgnos CreditAttribution: nomisgnos commentedFor stage_file_proxy.info.yml Doesn't this have to be updated to core_version_requirement: ^10 ?