Problem/Motivation

Add a "Disclaimer" field to the cookie texts (/admin/config/cookies/texts)
with the following default:
"All cookie information is subject to change by the service providers. We update this information regularly."

Description:
"Allows to place a disclaimer text above and below the cookie service information output. Leave empty to show no disclaimer. Ensure you update service information regularly anyway!"

The text should be a simple one-line input, optional, translatable and if not empty, output above and below the cookie information (/cookies/documentation + Token (+ perhaps the banner if the service detail informations are also shown there in a certain configuration))

Steps to reproduce

Proposed resolution

See above

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2022-12-01 13_21_31-Cookie Documentation _ Drush Site-Install.png49.34 KBGrevil

Issue fork cookies-3324484

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anybody created an issue. See original summary.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Assigned: Unassigned » Grevil

Grevil made their first commit to this issue’s fork.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Issue summary: View changes
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Parent issue: » #3324481: Allow for more structured Cookie Service information

Grevil opened merge request !71

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Status: Active » Needs review
FileSize
2022-12-01 13_21_31-Cookie Documentation _ Drush Site-Install.png49.34 KB

OK, I finished the implementation! I still need to implement tests for this and also go over the disclaimer styling (see screenshot attached). I wanted to style the disclaimer as a Drupal warning message, but failed (horribly).

Nevertheless, this is ready for review, but still needs a bit of work!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Needs work

@Grevil: Thanks, review done! :)
Regarding the tests perhaps add them all combined when finishing the parent issue? Might be easier, when you're in the flow ;)

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Title: Add "Disclaimer" dialog text field for cookie details » Revamp templates and add "Disclaimer" dialog text field for cookie details
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Title: Revamp templates and add "Disclaimer" dialog text field for cookie details » [PP-2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details
Status: Needs work » Needs review
Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Status: Needs review » Needs work

OK, this still needs work, couldn't finish it today, CookiesConfigService.php has huge flaws we need to fix...

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Status: Needs work » Needs review

OK, ready for review!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Title: [PP-2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details » [PP-1.2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Reviewed & tested by the community

RTBC once all points are fixed :)

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Version: 1.1.x-dev » 1.2.x-dev
Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Title: [PP-1.2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details » [1.2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details

  • Grevil committed 39a7d5c on 1.2.x 
    Issue #3324484: Add "Disclaimer" dialog text field for cookie details
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Assigned: Grevil » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.