In the past hour, we've gone from >200 patches CNR to 50. 75% of reviewable patches are unlikely to be at fault.

TestBot seems to have a problem installing the test sites.

Files: 
CommentFileSizeAuthor
#5 check_drupal_org.png6.09 KBboombatower

Comments

This is caused by #74645: modify file_scan_directory to include a regex for the nomask.. It went in, but breaks installation of HEAD entirely. There is a patch there to fix this.

Title:TestBot running berserk, clearing the Patch Review queue straight outTest clean HEAD after every commit
Category:bug» feature

This is actually not a problem with TestBot at all. TestBot is doing exactly what it should be doing. It's flagging when a patch results in HEAD not being able to install.

The problem is that an earlier commit broke HEAD so that it would not install. Therefore, all patches that got tested after that were also unable to install HEAD, and got flagged accordingly. It just so happened this commit landed just as Dries was likely headed to bed, and while I was taking a once-in-a-blue-moon rare trek *out* of my house to have lunch with hunmonk. :P There was a 4 hour window during which HEAD was broken, and that resulted in over 100 patches being tested, all of which failed.

Since human beings are fallible, I forsee this same situation will arise from time to time, either because one of us commits a patch erroneously, or because one of us commits a patch while the other person is committing a patch within a short window and TestBot doesn't have the chance to tell us "WAIT! Your new patch just broke things!"

Therefore, let's switch this to a feature request for TestBot to, after each commit, run a test of vanilla HEAD and if there are failures, immediately cease further testing and send e-mail to the devel list and the core committers.

Project:Project Issue File Review» Test driven development infrastructure
Version:6.x-1.x-dev»
Component:Code» Miscellaneous
Assigned:boombatower» Unassigned

Code is done, tested, and committed. I will deploy tomorrow when I get time (I have classes all day, but who doesn't code during class?).

http://drupal.org/cvs?commit=153399

Project:Test driven development infrastructure» Project Issue File Review
Version:» 6.x-1.x-dev
Component:Miscellaneous» Code
Assigned:Unassigned» boombatower

Project:Test driven development infrastructure» Project Issue File Review
Version:» 6.x-1.x-dev
Component:Miscellaneous» Code
Assigned:Unassigned» boombatower
Status:Active» Fixed
StatusFileSize
new6.09 KB

Also added a check for d.o being down which will send an e-mail to all admin users on t.d.o.

The code will also automatically turn itself back on once it detects that HEAD passes or d.o is live.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.