Problem/Motivation
@mglaman released version 1.1.33 of mglaman/phpstan-drupal
(See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.33)
Looking at https://www.drupal.org/node/3060/qa it removes some false positives on Level 1.
Steps to reproduce
See https://www.drupal.org/node/3060/qa and notice the failures on both updated deps
jobs for 10.0.x
, 10.1.x
and 11.x
Proposed resolution
- Upgrade mglaman/phpstan-drupal
- Create a new baseline (vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon
)
- Bump version of mglaman/phpstan-drupal in composer.json
to 1.1.33, since the newly created baseline won't pass on any version below that.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3361148
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
SpokjeComment #4
SpokjeComment #5
smustgrave CreditAttribution: smustgrave at Mobomo commentedDon't mind marking this for ya.
Comment #6
Spokje_tips hat_
Don't mind creating endless NR issues for ya.
_grins evilly_
Comment #8
longwavePushed and committed to 10.1.x and 11.x, thanks!