Problem/Motivation

@mglaman released version 1.1.33 of mglaman/phpstan-drupal (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.33)
Looking at https://www.drupal.org/node/3060/qa it removes some false positives on Level 1.

Steps to reproduce

See https://www.drupal.org/node/3060/qa and notice the failures on both updated deps jobs for 10.0.x, 10.1.xand 11.x

Proposed resolution

- Upgrade mglaman/phpstan-drupal
- Create a new baseline (vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon)
- Bump version of mglaman/phpstan-drupal in composer.json to 1.1.33, since the newly created baseline won't pass on any version below that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3361148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Issue summary: View changes

Spokje’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Don't mind marking this for ya.

Spokje’s picture

_tips hat_
Don't mind creating endless NR issues for ya.
_grins evilly_

  • longwave committed 0d87fe01 on 10.1.x
    Issue #3361148 by Spokje: Update mglaman/phpstan-drupal and make daily "...
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Pushed and committed to 10.1.x and 11.x, thanks!

  • longwave committed eb39373a on 11.x
    Issue #3361148 by Spokje: Update mglaman/phpstan-drupal and make daily "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.