Problem/Motivation
https://github.com/ckeditor/ckeditor5/releases/tag/v38.0.0
👇 Highlights:
- Most of the
Style
plugin-related problems surfaced in #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements are fixed! This is the #1 blocker for sites upgrading from CKEditor 4 to 5 — see #3340578: [meta] [upstream] Prioritized CKEditor 5 upstream blockers. - They introduced a "Powered by CKEditor" logo:
From version v38.0.0 onwards, all open-source installations of CKEditor (using it under the GPL terms) will carry a small “Powered by CKEditor” logo in the bottom-right corner of the editing area. This new logo links directly to the CKEditor website to strengthen the awareness of who’s powering and modernizing their rich text editor.
This change does not affect customers with commercial licenses. You can reach out to our Technical Support team using this form, if you have any questions.
See https://github.com/ckeditor/ckeditor5/issues/14082 for their rationale.
Steps to reproduce
Proposed resolution
- Update
core/package.json
cd core
yarn install
yarn build
yarn build:ckeditor5-types
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
CKEditor 5 has been updated to 38.0.0
Issue fork drupal-3361800
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
Wim LeersComment #4
Wim LeersPer release manager @catch in #3326261-34: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements, tagging this as a for
10.1.x
.Comment #5
neclimdulJust an observation as this is an expected upstream change but tested and noticed there's a new powered by baloon on editors now. Seems this is an upstream change that affects opensource installs.
https://github.com/ckeditor/ckeditor5/issues/14082
Edit: I'm an idiot and got excited to review and didn't read the full IS... its all there.
Comment #6
smustgrave CreditAttribution: smustgrave at Mobomo commentedLeft a comment on #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements where I found a bug.
But overall ckeditor update appears to be working. Haven't found a regression. Since ckeditor_styles almost doesn't work this works better even if it's got a bug or two.
Comment #9
longwaveCommitted and pushed 47c4939fec5 to 11.x and eb08f0528da to 10.1.x. Thanks!
Also updated the release notes.
Comment #11
pixelwhip CreditAttribution: pixelwhip at Aten Design Group for Richland Library commentedIs there any chance of this being applied to the 9.x branch? We're still a couple months out from moving to 10.x but I'd like to roll the Ckeditor5 upgrade out sooner if possible. If not, what is the recommended method for changing to a custom build of ckeditor5?
Edit: I just saw this comment. https://www.drupal.org/project/drupal/issues/3326261#comment-15060319 which I think answers my first question.