Problem/Motivation

https://github.com/ckeditor/ckeditor5/releases/tag/v38.0.0

👇 Highlights:

Steps to reproduce

Proposed resolution

  1. Update core/package.json
  2. cd core
  3. yarn install
  4. yarn build
  5. yarn build:ckeditor5-types

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CKEditor 5 has been updated to 38.0.0

CommentFileSizeAuthor
#5 image.png4.01 KBneclimdul

Issue fork drupal-3361800

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers’s picture

neclimdul’s picture

FileSize
4.01 KB

Just an observation as this is an expected upstream change but tested and noticed there's a new powered by baloon on editors now. Seems this is an upstream change that affects opensource installs.

picture of the bottom right corner of a ckeditor textarea with a powered by ckeditor box

https://github.com/ckeditor/ckeditor5/issues/14082

Edit: I'm an idiot and got excited to review and didn't read the full IS... its all there.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Left a comment on #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements where I found a bug.

But overall ckeditor update appears to be working. Haven't found a regression. Since ckeditor_styles almost doesn't work this works better even if it's got a bug or two.

  • longwave committed eb08f052 on 10.1.x
    Issue #3361800 by Wim Leers, neclimdul, smustgrave: Update CKEditor 5 to...

  • longwave committed 47c4939f on 11.x
    Issue #3361800 by Wim Leers, neclimdul, smustgrave: Update CKEditor 5 to...
longwave’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 47c4939fec5 to 11.x and eb08f0528da to 10.1.x. Thanks!

Also updated the release notes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pixelwhip’s picture

Is there any chance of this being applied to the 9.x branch? We're still a couple months out from moving to 10.x but I'd like to roll the Ckeditor5 upgrade out sooner if possible. If not, what is the recommended method for changing to a custom build of ckeditor5?

Edit: I just saw this comment. https://www.drupal.org/project/drupal/issues/3326261#comment-15060319 which I think answers my first question.