Problem/Motivation

List of migrations fails when disqus is enabled, but (core) migrate_drupal is not.

Steps to reproduce

  1. Uninstall disqus (if it is enabled)
  2. Enable migrate, migrate_tools and migrate_plus modules
  3. Create a migration
  4. Enable disqus
  5. Go to admin/structure/migrations
  6. List of migrations is empty

Why this happens:

in function disqus_migration_plugins_alter():

<?php

  $disqus_plugin = DisqusDeriver::getSourcePlugin('disqus_enabled_content_types');
  assert($disqus_plugin instanceof DrupalSqlBase);

?>

Full class name of DrupalSqlBase is Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase, so, if migrate_drupal is not installed, $discus_plugin won't be created, resulting in an empty list of migrations.

Proposed resolution

Check that migrate_drupal is enabled

Remaining tasks

Write the patch

Issue fork disqus-3387071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

valthebald created an issue. See original summary.

valthebald’s picture

Status: Active » Needs review

robloach made their first commit to this issue’s fork.

  • robloach committed 1a9dc60f on 2.0.x authored by valthebald
    Issue #3387071: Alter migration plugins only when migrate_drupal is...
robloach’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.