Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It's just a simple code style fix.
I also removed some stupidity where it was setting $permisions to default to NULL, and then if it was null then set it to the default array. Since there are no additional parameters, this is pointless.
Also, checkPermissions becomes private simply because it doesn't need to be protected (no one should use it).
Comment | File | Size | Author |
---|---|---|---|
#2 | 340081-drupalCreateUser.patch | 1.46 KB | boombatower |
private_permissions_simpletest.patch | 1.92 KB | dmitrig01 | |
Comments
Comment #2
boombatower CreditAttribution: boombatower commentedThe permissions need to be defined on drupalCreateUser() then, you can't just move the default in drupalCreateRole()...which is why the tests failed.
Comment #3
boombatower CreditAttribution: boombatower commentedComment #4
Dave ReidAlso see #300993: User roles and permissions API.
Comment #5
dmitrig01 CreditAttribution: dmitrig01 commentedRead through code, looks good, bot passes.
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.