Remove Dependency on Extra Voting Forms (Test Alternative Voting Modules)

Extra Voting Forms is mentioned at http://www.drigg-code.org/pages/download_and_install - there may well be a dependency. I'm using the Drupal 6 dev version and I have a similar behaviour if the Extra Voting Forms is disabled. At the moment, even with it enabled, so far, all I get is a voting form where I should see my drigg_home page.

This should be another simple fix.

Simply add the following line to drigg.info:

dependencies[] = extra_voting_forms

Hi,

I am not keen on adding a dependency, because Drig itself doesn't depend on it. It's "default theme" does.
YOu can use other module widgets -- and people do. Drigg is totally voting-widget-agnostic. And there is no way to make a theme dependent of a module.

So, I think this is about writing in the documentation that the default theme depends on Extra Voting Forms. Drigg doesn't...

Merc,

Hi,

Drigg's theme has always depended on extra_voting_forms from day 1.
Maybe what we are missing, in the theme file, is a check to see if the module extra_voting_form is actually installed before calling the module-specific code?

Plus, maybe we could add a warning in the default template if EVF is not installed, so that people are aware?

Merc.

Related for D7: #474684: Allow themes to declare dependencies on modules

Hi,

This is a duplicate of #339918: Unnecessary Dependency for Embedded Objects Module which will hopefully be closed soon....

Bye,

Merc,

Keeping these issues separate to ensure other voting forms can take the place of Extra Voting Forms to ensure there is actually no dependency. I also want to do more testing focused on the fix for the default theme.

Proposed Default Theme Fix...

Change:
print extra_voting_forms_show_form($node,'n',3);

To This:

  if( module_exists(extra_voting_forms) ){
    print extra_voting_forms_show_form($node,'n',3);
  }

This isn't really a bug since Extra Voting Form is the support module for Drigg. We can expand to other voting module. Marking as a task.

Hi,

Philbar, I think it would be better to apply this change (I think it's the only one) to the theme, and then maybe open a new task about investigating using other voting widgets.

Bye,

Merc.

I'm working on adding the fix. I haven't ever experienced the problem, so it will take a bit more time to get caught up to speed on this issue.

I want to make sure...

print extra_voting_forms_show_form($node,'n',3);

...is the only code requiring extra voting forms. You fix will probably do it, but I need some time to test it.

Also, I don't want to flood the issue queue anymore than I already have, so I'm going to keep the testing voting modules in here for now.

Hi,

That is the only spot:

root@merc-laptop:/home/www/drupal/current_6/sites/all/modules/MAINTAINED_BY_MERC/do/drigg/stock_themes# grep -i extra_voting `find .`
./4plus/node-drigg.tpl.php: print extra_voting_forms_show_form($node,'n',3);
./drigg_theme/node-drigg.tpl.php: print extra_voting_forms_show_form($node,'n',3);
root@merc-laptop:/home/www/drupal/current_6/sites/all/modules/MAINTAINED_BY_MERC/do/drigg/stock_themes#

But, there is ANOTHER spot, and that's in ./drigg_users/drigg_users.module: the default values for the voting form is extra_voting_forms.

The last dependency is here: ./drigg_approval_queue/drigg_approval_queue.module Now that's a bit of a bugger, and it's evidence that using ugly hacks always brings you problems later. But, I guess this is not a big deal really, meaning that we can live with it until we find a better way of avoiding the hack.

I would honestly comit the if() in #8 and open a new task to get rid of the dependency, where you list the two extra semi-dependency I wrote here.

Merc.