Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The "Show enable/disable rich text toggle link" checkbox in the Wysiwyg profile configuration settings does not prevent the "Disable rich-text" link from appearing below a WYSIWYG-enabled textarea.
I'm using Drupal 6.6 with wysiwyg-6.x-0.4 and TinyMCE 3.2.1.1.
Looking at wysiwyg.js, it appears that it unconditionally adds the enable/disable link without checking the showToggle value. I've attached a patch that fixes the problem.
Comment | File | Size | Author |
---|---|---|---|
#26 | wysiwyg-HEAD.toggle.patch | 7.98 KB | sun |
#12 | wysiwyg_patch.diff | 860 bytes | kishorevaishnav |
wysiwyg.js_.patch | 618 bytes | igwk |
Comments
Comment #1
markus_petrux CreditAttribution: markus_petrux commentedI think this is working in latest dev snapshot. A new 0.5 release is pending on this one: #322657: "Enabled by default" option does not work when disabled
Comment #2
sunGood catch. However, configuring this per wysiwyg profile no longer works out. Seems like we need global wysiwyg settings now?
Comment #3
sunProper version and status (active, because the existing patch is not a solution; see #2).
Comment #4
weimeng CreditAttribution: weimeng commentedJust pointing out that this issue still exists in the 16 Dec 2008 5.x-1.x-dev build.
Comment #5
blinko CreditAttribution: blinko commentedSame here! The option does not disable the button...
(Drupal 6.8 + latest dev version + TinyMCE latest)
Comment #6
Mark Theunissen CreditAttribution: Mark Theunissen commentedsubscribing
Comment #7
chaloalvarezj CreditAttribution: chaloalvarezj commentedsubscribing..
Comment #8
jarchowk CreditAttribution: jarchowk commentedAny word with this?
Subscribing
Comment #9
Freso CreditAttribution: Freso commentedJust wanted to note that this is also present in the 6.x-1.0 release.
Comment #10
Soukee CreditAttribution: Soukee commentedSame problem here. Need to insert teaser break and exclude the teaser from the body of node. Any solution pls?
Comment #11
Shai CreditAttribution: Shai commentedSame problem... subscribing.
Comment #12
kishorevaishnav CreditAttribution: kishorevaishnav commentedThe patch updated above points to line no. 49 but when i worked out it seems to be at the line 79. I think this patch will work better. Let me know if it doesnt works out.
Comment #13
sunIt does not work out. See #2.
Comment #14
thinguy CreditAttribution: thinguy commentedSame problem. Any fix?
Comment #15
rconstantine CreditAttribution: rconstantine commentedThe patch in #12 seems to work for me using FCKEditor and 6.x-2.x-dev version. Of course, I had to manually apply the patch since the line numbers no longer match. I was able to toggle the checkbox and see the desired results both times.
Comment #16
pingu2k4 CreditAttribution: pingu2k4 commentedsubscribing...
REALLY need this fixed ASAP please
Comment #17
sunOh? You need this fixed ASAP? So why didn't you provide a patch others can test?
Comment #18
sinasquax CreditAttribution: sinasquax commentedFor me this patch works :
replace :
Drupal.wysiwygAttachToggleLink(context, params);
by :
Comment #19
iamwhoiam CreditAttribution: iamwhoiam commentedthat did the trick to remove the menu if tick box is unticked. But when you retick the checkbox, the link doesn't return.
Comment #20
simanta CreditAttribution: simanta commentedI have used wysiwyg v6.x-1.1 in my project and got the same problem. But I get rid of that bug using the following patch:
replace :
Drupal.wysiwygAttachToggleLink(context, params); //Line 82 at the above mentioned versionby :
// Attach or update toggle link. if (Drupal.settings.wysiwyg.showToggle) { Drupal.wysiwygAttachToggleLink(context, params); }Comment #21
ailgm CreditAttribution: ailgm commentedsubscribing
Comment #22
danielb CreditAttribution: danielb commentedcomment deleted
Comment #23
torrance123 CreditAttribution: torrance123 commentedSubscribing.
Comment #24
dhestlund CreditAttribution: dhestlund commentedSubscribing... sry for other users' impatience. Great module guys!
Simanta's code worked like a charm for me, toggling both ways. Hoping this gets incorporated by next release (I'm forgetful).
Comment #25
myDRU CreditAttribution: myDRU commentedPatch proposed in #20 above works fine (I justed installed wysiwyg 6.x-2.0-alpha1 and tinymce 3.2.4.1, where the patch is still needed).
Hope this small patch will become part of the wysiwyg 6.x-2.0-alpha2.
Comment #26
sunMeh. It would be nice if people would listen to what I say.
Attached patch needs testing.
Comment #27
sunI guess that most of you don't know how to apply this patch. So.
Thanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #29
joachim CreditAttribution: joachim commentedI've just installed the latest dev version and the toggle doesn't appear.
> grep showToggle *
produces only one result -- can't be right, surely?
Comment #30
sunSee #489156: Remove orphan 'showToggle' global JS setting :)
Comment #31
sunAs well as #545210: Default module behavior should match profile settings default (much more likely the issue you encountered)
Comment #32
joachim CreditAttribution: joachim commentedDoes this mean it's still possible to toggle off the wysiwyg?
Being able to switch to SANE mode on a site where the client insists on a wysiwyg is really necessary!
Comment #33
sunYes, that should work now. At least, this patch was committed to fix the bug in 2.0 where it did not account for the profile configuration setting at all.