Add editor: YUI Rich Text

Here's the basic yui.inc file

-- It's only loading one of the library files, which is yahoo-dom-event.js not sure why
-- Unsure how to add more complex items to yui toolbar, this would include select list, spell check etc... I need to take a closer look at tinyMCE
-- Same goes with creating the yui.js which is able to load and unload the editor when selecting input formats

Couple editing errors in the last file, nothing that would stop it from working though. Just cruft left over from my copy and paste.

Here's the new yui.inc that builds the js based upon which settings you have enabled.
And I added some code to yui.js that will take these settings into account, but still getting some errors. So I commented them out but still may be useful and save some time.

Here's a patch that does grouping. I based it off of how you did button settings. Still doesn't seem as streamlined as it should be, too much hardcoded. But It is outputting the buttons in expected array structure.

patch needs work

In reference to the non-working patch above. It leads me to believe we're missing an extra wrapper to YAHOO.widget.Editor.
Here's code that is working for our site in Drupal 5 using a modified version of YUI Editor module

<script type="text/javascript" src="/sites/all/modules/custom/yui_rte/js/yui_rte.js"></script>
<script type="text/javascript" src="/sites/all/modules/custom/yui_rte/toolbars/yui_rte_toolbar_simple.js"></script>

<script type="text/javascript">
        if (Drupal.jsEnabled) { 
          $(document).ready(function() { 
            $('body').addClass('yui-skin-sam'); 
          }); 
        }
        // safari submit button always defaults to first 'button' available on page (example: 'preview')
        // core YUI RTE issue http://drupal.org/node/321863. Do not display RTE in Safari for now.
        if (!$.browser.safari) {
          YAHOO.util.Event.onDOMReady(function() { 
            YAHOO.Drupal.editors.push(new YAHOO.Drupal.yui_editor('edit-body', { "height": "240px", "smiley": 1, "smiley_path": "/sites/all/modules/custom/yui_rte/images/smileys/", "base_path": "/", "markup": "xhtml" })); 
 YAHOO.Drupal.yui_editor_load.fire();
          }); 
        }
</script>

REFER TO COMMENT #14

Here's another patch. Some of the Checkboxes on configuration page were improperly named (parastyle instead of formatselect), couple other changes.

REFER TO COMMENT #14

Here's a patch that has been ran the proper way
diff -urp oldfile newfile > patch_name.diff

Grouping still doesn't work

REFER TO COMMENT #14

This is patched against HEAD.
You can see the grouping is working fine. It's how we are listing 'buttons' within the group array that seems to be borked.

It's getting close. Any suggestions would be appreciated.

SIMPLIFIED
Here's a more streamlined way to do grouping. I believe we'll be able to do grouping with external plugins if we go this route.
This is a patch against HEAD.

Ignore patches from comments #11, #12, & #13

I just noticed something else that might help figure this out...
If you apply my last patch and uncomment line 191, you'll see the grouping titles appear like they are supposed to. Here's a screenshot

EXAMPLE 1

$settings['toolbar']['buttons'] = array_merge(array('type' => '', 'label' => '', 'value' => ''), $grouped_buttons);

now if you slightly modify this code to be the following

EXAMPLE 2

$settings['toolbar']['buttons'][] = $grouped_buttons;

You'll see an undefined button appear, Here's a screen shot.

So lets look at the differences in output to see what's allowing this button to appear.

EXAMPLE 1

"buttons": [{
    "group": "textstyle",
    "label": " Font Name and Size",
    "buttons": [{
        "type": "push",
        "label": "Bold",
        "value": "bold"
    }, {
        "type": "push",
        "label": "Italic",
        "value": "italic"
    }, {

EXAMPLE 2

"buttons": {
    "type": "",
    "label": "",
    "value": "",
    "0": {
        "group": "textstyle",
        "label": " Font Name and Size",
        "buttons": [{
            "type": "push",
            "label": "Bold",
            "value": "bold"
        }, {
        "type": "push",
        "label": "Italic",
        "value": "italic"
        }, {

I guess the only real thing that jumps out at me is the first occurrence of 'buttons' in both instances.
Example 1 has "buttons": [{ /// no buttons
Example 2 has "buttons": { /// undefined button

I'm not a JS expert but I believe this may be the reason why we are getting NULL values for this._buttonList in editor.js
How can we get EXAMPLE 1 to output more like EXAMPLE 2???