IE7: Offset between browser viewport and menu in themes with body { position: relative }

Is it possible that $closure is not output directly in the BODY element, or some margin/padding-top is applied to BODY in your theme?

Are you able to replicate this issue in other themes (not YAML based)? Also, does the issue resolve if you remove the padding from BODY?

I have seen admin menu on many different sites and themes in the meantime (not even built by me) and there is even the Administration menu showcase site (see link on project page), which demonstrates approx. 50 themes from drupal.org (none of them built or customized by me). I did not experience this issue with any of those themes.

Not really. It applies a margin-top to BODY, i.e. it shifts down the page's contents by 20 pixels to make room for the administration menu. This behavior can be disabled via admin menu's settings page.

Please note that if you do not apply any styles to BODY, then most browsers will use a default margin of 10 pixels.

So did you test with another theme? This may be a bug if you can replicate this issue in more than one theme.

Yes, that's what I meant in #7: The administration menu is absolute positioned at top: 0;, so the body is shifted down to make room for it.

Because of this, your patch does not make much sense. Since an absolute positioned element is always positioned at the defined position, it is irrelevant whether there is an element before or after it in the markup. div#admin-menu is still positioned at top: 0.

That said, IE is known to render proper CSS wrong under certain circumstances. That's why I asked whether there might be some padding/margin applied to the body, or $closure may not be output as a direct child of body, which both have been the cause for other users in the past (see README.txt). Another possible cause could be a defined width, height or overflow: hidden property for the body element, which triggers IE's hasLayout property for the DOM element. IE's hasLayout property, in turn, most often leads to unexpected rendering of page elements.

So, to repeat: The current CSS/JS is working using IE5.5, IE6, and IE7 in all themes I have tested. And you can trust me, I have tested many themes. Countless hours have been spent to assure that this stuff works properly in IE, Firefox 2, Firefox 3, Firefox/Mac, Safari, as well as Opera. If you want to convince me that this is a bug, which not only occurs in your theme (or YAML-based themes), you obviously have to prove it. That said, there is always a chance a bug slipped in somewhere and it is perfectly possible you found one. However, due to the aforementioned, enhanced testing, a bug needs to occur in most themes, not only in 0.1% of all themes - otherwise the fix for those particular themes will break 99.9% of all other themes, which is the gained experience of insufficiently tested CSS changes in administration menu.

Hence, please ensure that you are able to replicate this bug in other themes. If you cannot, then your theme needs to be fixed instead (for the reasons I tried to outline above).

Reverting status to active to prevent people from mistakenly testing this patch.

It seems you are ignoring my replies. Yes, I looked at the patch, explained in detail why it just won't work, and reverted the issue status to prevent innocent victims from discovering and applying that patch. All of this was in #10.

Changing issue properties according to #12.

The fix is simple: Just wrap your contents into another container (i.e. BODY > DIV) and apply position: relative; to this container instead.

I see no reason why styles applied on a DIV would suddenly behave differently than on the BODY element. "Full height layouts" need further CSS tricks either way, and it is completely irrelevant whether those tricks are applied to the BODY element or a child container instead.

Look, I have no idea what YAML does and why it needs this CSS styling on the body element. All I know is that admin menu renders fine in all other (i.e. not YAML-based) themes, regardless of the browser. I see no way of fixing this issue in admin menu properly for regular themes as well as YAML-based themes. Additionally, I can already foresee and do not even need to test that admin menu's output/styling is not the only one that breaks in YAML due to those irregular styles applied to the BODY element. Hence, if YAML's styles are guilty, then I would work on fixing YAML instead.

Your second option obviously is to override admin menu's styles in your theme, which is the usual way to customize default styles of modules for your own, custom theme.

Sorry, holidays.

Every site that have this annoying IE7 zoom bug fixed have this issue with admin-menu!

That is plain wrong. I have personally seen, tested, and used admin menu on many sites, even on sites fulfilling the highest accessibility standards. Your "solution" of applying position: relative to the body is a CSS hack and is as error-prone as every other CSS hack. The amount of people who care about this "bug" effectively cuts down to the number of sites that are using this CSS hack.

If at all, the patch for this issue should probably look like the attached one. However, this patch will break the design/layout of sites that use a background image for the body (which is a far more common case than applying position: relative to the body).

Aside from that, a patch like this needs review and confirmations for all browsers and platforms, since it alters an important part of admin menu.

DIV elements are allowed to be empty, even in the XHTML Strict DTD. Also, the height should be rendered fine in all browsers and platforms. FWIW, your previous patch applied a border-bottom to the body element, and not to the injected DIV element, so the resulting height of the DIV was only equal to admin menu's height by coincidence, which is why it was wrong.

You cannot mark your own patch as RTBC. That's why the status is called "reviewed & tested by the community".

adding accessibility tag

@mgifford: Does that mean you can replicate this issue? You would be the first one aside from hass.

Needs work since #415196: CSS Coding Standards Patch went in. Patch needs to be against 3.x.

I don't generally use windows at all, so didn't actually replicate the issue, sorry.

I use admin menu a bunch and haven't heard problems with the positioning.

I doing my best to get rid of display:none; though.

Wish I could confirm/deny this, but was speaking more to the followup comments than the reported bug.

It seems like none of the 51,860 (minus one) users can replicate this issue. All other issues of this category would have at least one follow-up of at least one other user who experienced the same issue.

That means, this patch was not even considered - nor tested - by anyone, including myself. In turn, this means I cannot blindly commit this patch unless there are some other users confirming.

Closing issue.

@hass we need more info.

It seems it is outdated because Drupal 6 is EOL (End-of-life) and will no longer be supported.

In case if you or anyone is still facing on Drupal 7/8, please to reopen it, change the version and provide with more information and a screenshot which might help us to troubleshoot. :)