Great work on this [#346537]

I've been fighting Zen for months - then I found Basic and it seems to be just what I needed. I really just wanted to congratulate you guys on a great theme.

While I'm here, one thing: something that is missing for me is the ability to add custom content type template suggestions. It's easy enough to add and really a great way to theme various areas of a larger website that have completely different content / layouts.

I just added this to the template.php file:

	// Add template suggestions based on content type 
	if ($vars['node']->type != "") {
    $vars['template_files'][] = "page-node-" . $vars['node']->type;
  }

then make your page-node-my_content_type.tpl.php and you're good to go.

It's really only useful in conjunction with cck, so maybe it has no place in a bare bones theme.

The only things I miss from Zen are the breadcrumb settings controls and and ability to rebuild the registry every page load. I can live without those though.

Anyway, great work.

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 13 December 2008 at 09:21

Assigned:	Unassigned	»
Status:	Active	» Needs review

The "rebuild the registry" thinguy will be in the next version of Basic 2, with the settings of the block edit links.
For the breadcrumb, it's a little too specific for basic's simplicity. The amount of code to add is pretty heavy for something that might not be usefull for all project.

I'll try that little function you added, it looks pretty cool, and light, and even if it's related to cck, I can't imagine Drupal without CCK, so it's valid to me :)

Thanks for the support, it's always a treat.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 5 May 2009 at 18:44

Status:

Needs review

» Fixed

Submited to dev :

if ($vars['node']->type != "") {
      $vars['template_files'][] = "page-type-" . $vars['node']->type;
    }
  if ($vars['node']->nid != "") {
      $vars['template_files'][] = "page-node-" . $vars['node']->nid;
    }