Hi folks:

Thanks for building this theme. I am not sure if this is a bug or if I did something wrong. I seem to be having difficulty getting the fieldset formatting to work. I noticed that there are two things happening:

1) On the edit content areas, all of the expandable pieces are not able to be expanded, and there is not an image for the arrow be able to open and close the fieldsets. I have temporarily changed this function over to the Garland in order to be able to use it. This happens both in FireFox and IE6.

2) On the user editing page, using the admin, when I open up a person's username and click edit, there are a whole bunch of fieldsets that are crunched up to the top of the page, overlaying other areas. Specifically, the theme configuration information is overlaying other information. This happens in both FireFox and IE6, and I also believe Safari.

I have attached a couple of screenshots. Perhaps it will be something that you have seen before.

Thanks

Brian

Files: 
CommentFileSizeAuthor
Basic_Template.pdf331.52 KBbrianosaur

Comments

Category:bug» support
Status:Active» Postponed (maintainer needs more info)

Hi Brian,

So I just had a look at your PDF, thank you very much for making this, it really helps. From what I can see, it doesn't look like a Basic bug, as this don't happen in a default install, but that might be because of your install. Two things :

1/ The fieldset not being loaded properly looks like a Jquery problem. Could you make sure that these files are called in the head :

/misc/jquery.js
/misc/drupal.js
/misc/collapse.js

Also make sure that they are not missing in the misc folder.

Another possibility, is that you might have overridden the theming output of the fieldset, and change the class that they should have... did you do anything that could have change the way fieldset are build ? (like adding a theming function in your template.php or adding a module that would interfere with this)

2/ The fields overlapping each other look like a float not being cleared OR a line-height that would be way too small. Did you create any css that would make one element in the form float, like a label or such ?

For this kind of problem, as I see that your are using firefox, I would really recommend that you use firebug, it is a very nice addon of firefox that will help you tweak the css and find where bugs are hidding:

https://addons.mozilla.org/en-US/firefox/addon/1843

Hope that helps.

Interesting. I am seeing the drupal.js and the jquery.js, in the head of the page code, but not the collapse.js. Do you know which file I should add that to?

OK, I added that line to the includes/common.inc file and it appears that the first problem (the user edit page) has been resolved. The edit content page still seems to be missing the ability to expand. It is in a collapsed state and there is no arrow or line that allows your to click it into an expanded state. That was the second and third image in the pdf file that I attached. Any thoughts on that one?

Thanks again.

Brian

Did you add any javascript in your page template ? Sometimes it interfere with it.

As a quick and dirty fix, you can add this to your template.php, until you fix it. (without the php opening and closing tags)

<?php
//this appears in my theme template.php file
global $user;
if (
$user->uid == 1) {
   
drupal_add_js("/misc/collapse.js");
}
?>

Thanks. I will give that a try. I don't recall putting any code in the templates. The only thing that I can think of is that the site was built before the domain was pointing to the proper place. It messed up the base URL location and that had to be fixed manually. I am due to upgrade to 6.8, so I wonder whether I should try this with a clean install and see if things go back to normal.

Given that Drupal seems to have updates pretty regularly, I am trying not to skew the code of my site, because then I have to put my customized code back in after updating, which is not my favorite thing.

The Garland theme seems to have the collapse working and currently that is the administration theme that I am using for the editing until I can fix this. Thanks for your assistance on this. Oh yeah Firebug is really great too!

Brian

Ok, I had a look at your theme, and here is what is going on:

- The fieldset are not working because of a conflict with another Jscript.
In your page template, your are calling 2 other scripts : jquery-1.2.3.pack.js and jquery.embedquicktime.js . the problem is that you are calling them 2 times, and in one of the call, there is this : jQuery.noConflict . This seams to be the reason why the fieldset are not working. Here is what you can do, delete all the script calls you added in your page.tpl.php and add them in your template.php like this :

drupal_add_js('modules/embed_quicktime/jquery-1.2.3.pack.js', 'theme');
drupal_add_js('modules/embed_quicktime/jquery.embedquicktime.js', 'theme');

That would fix your expanding problem, and on a side note, I would recomend that you use the jquery update module instead of calling a second jquery file (the one with 1.2.3):
http://drupal.org/project/Jquery_update

Also, have you tried this ? :
http://www.solitude.dk/archives/20071201-2218

- Now the fieldset style problem comes from th line 49 of styles.css : you are setting a height for the fieldset (20px) so even expanded, they won't behave like hey are tallerr than 20px. By just removing that height, or removing 'fieldset' from that css rule, you fix your problem.

Now you can also delete all the fieldset css rules in style.css as you are repeating them in main.css

Does all this makes sense ?

Yes, many thanks! I will get that all in there and give it a test.

Status:Postponed (maintainer needs more info)» Fixed

Fixed I guess...

Thanks, just took a look back at this. The old version was still acting funny but the new beta version fixed all the issues. Yes. Thanks a bunch!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

I had this problem and it was because I had settings in Performance page to cache Javascript. Was driving me crazy since I replaced all of misc, etc.