Submit of a form that has been loaded with ajax posts to the ajax callback URL [#350102]

on the admin form
click add tab->click save->(validation fail, but just leave it like that)->click save again
results in a redirect to quictabs/ahah where json data is displayed

and a similar problem with this patch350102

Index: includes/admin.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/quicktabs/includes/Attic/admin.inc,v
retrieving revision 1.1.2.20
diff -u -p -r1.1.2.20 admin.inc
--- includes/admin.inc 4 Dec 2008 17:08:15 -0000 1.1.2.20
+++ includes/admin.inc 4 Dec 2008 17:09:08 -0000
@@ -426,7 +426,7 @@ function quicktabs_form_submit($form, &$
       quicktabs_createblock($quicktabs);
       drupal_set_message(t('Your Quick Tabs block has been created and can now be enabled.'));
     }
-    drupal_goto('admin/build/quicktabs');
+    $form_state['redirect'] = 'admin/build/quicktabs';
   }
}

after applying this patch
click add tab->save->(validation fail) fill title->save
results in a redirect to quictabs/ahah where json data is displayed

Comment	File	Size	Author
#5	quicktabs-350102-5.patch	1.51 KB	Berdir
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 22 January 2009 at 16:34

Issue tags:

+Release blocker

Comment #2

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 8 June 2009 at 05:28

the bug exists in D7: #484838: [rfay version] AJAX form can submit inappropriately to system/ajax after failed validation

Comment #3

Pasqualle

🇭🇺 Budapest

CreditAttribution: Pasqualle commented 11 February 2010 at 02:28

#671184: AJAX form can submit inappropriately to system/ajax after failed validation

Comment #4

tbenice CreditAttribution: tbenice commented 13 September 2010 at 23:03

same thing happens in RC5 and this is the recommended release.

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 27 January 2014 at 14:17

Title:	json data displayed on the admin form	» Submit of a form that has been loaded with ajax posts to the ajax callback URL
Version:	6.x-2.x-dev	» 7.x-3.x-dev
Issue summary:	View changes
Status:	Active	» Needs review

File	Size
quicktabs-350102-5.patch	1.51 KB

Confirmed, attached is a more or less ugly workaround.

Quicktabs is already messing with $_GET['q'] but the form system doesn't rely on that (at least not in 7.x) but request_uri(), which uses in $_SERVER['REQUEST_URI']. Replacing that directly seems to crazy, this instead sets a global helper variable, which is then checked in a form_alter(), where all forms are updated accordingly.

Attaching a patch for 7.x-3.x, updating issue accordingly.

Comment #6

mharbi CreditAttribution: mharbi commented 9 May 2014 at 08:36

5: quicktabs-350102-5.patch queued for re-testing.

Comment #7

Elin Yordanov CreditAttribution: Elin Yordanov commented 29 September 2015 at 15:36

I can reproduce this bug only on a Windows (IIS) Server. On Linux server and on my local linux machine it is not reproducible.

I applied the patch #5, but unfortunately the problem still exists.

Comment #8

Elin Yordanov CreditAttribution: Elin Yordanov commented 30 September 2015 at 08:07

Status:

Needs review

» Needs work

I've tested the patch and it is unfortunately not working on Windows (IIS) Server. On a Linux machine I cannot reproduce the issue even without patching. So it seems it is somehow related to Windows or IIS.

Comment #9

Elin Yordanov CreditAttribution: Elin Yordanov commented 7 October 2015 at 13:24

Ok, my issue is related but not exactly the same. Let's try to explain:

I've a quicktabs with AJAX-loading tabs. In each tab there are listings of node titles and 'Edit' links for each node. If I click the edit link, the node edit form opens in overlay. Everything is OK until here. If I save the form, the node is saved as expected, but I get a JSON-response instead of being redirected back to the quicktabs listing.

This problem occurs only if the node edit form is called from a tab which is loaded via AJAX. On the initial tab, which is loaded on page load without AJAX, everything is ok. And as stated on my previous comment, I cannot reproduce it on Linux (Apache) machines, only on Windows (IIS).