Suckerfish to Superfish [#354974]

I use Superfish in other styles and started converting Jazzlite to Superfish. It seems to work ok. Are you interested in Superfishing Jazzlite?

I load superfish css and jss using superfish.module. The module also adds the right class so I can use superfish unmodified. Superfish works as a replacement for suckerfish in most of the suckerfished themes I have tried so far. Superfish could easily go into Drupal core.

Comment	File	Size	Author
#13	super.jpg	167.7 KB	bwv

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

pokadan CreditAttribution: pokadan commented 21 January 2009 at 18:59

So you are going to use a module to do some of the work? That sounds great. I've been having some issues with nice menus(suckerfish) and would love to be able switch. Could you pls link to the superfish.module you were talking about..

Thanks,
Dan

Comment #2

peterx CreditAttribution: peterx commented 22 January 2009 at 04:01

drupal.org will not let me attach zipped files so go to: 02d.in/sites/all/modules/superfish/superfish.7z
The file contains a module that contains Superfish in subdirectories. The module adds the CSS, the javascript, and adds the sf-menu class to anything with a class of menu. I tested the module with a couple of themes and it worked. Some themes need the right options turned on to create the right menu.

If you want to make superfish into a formal drupal module, I am happy to help support it because I use it. At this stage it does what I want and I do not need anything else. Some documentation might help. The change log from the original superfish download is in the subdirectory with the version number.

I use the module in the all directory of a multisite and switch the module on for sites that use the right theme. The multisite has a few sites with Jazzlite in various colours. I just started testing with themes outside Jazzlite. When I try supersish with more themes, I might make up a list of themes and the settings for each.

Comment #3

pokadan CreditAttribution: pokadan commented 22 January 2009 at 13:05

Hi, I'm possibly not the best suited to give advice. But instead of writing about bunch of configuration settings for existing themes it may be a better idea to let future theme creators know how to support your module. And that would consist the documentation for the module..

On another note, I've tested your module on Zen classic and Bluemarine and the class of "sf-menu" does not get added to menus and generally nothing happens. Let me know what I have to do to have superfish working in a theme, pls

Thanks you so much,
Dan

Comment #4

peterx CreditAttribution: peterx commented 23 January 2009 at 00:19

Documentation from new superfish.module. superfish.7z is updated. I had to do something weird for litejazz-6.x-1.7 because there is a duplicate ul element. I might move the documentation into a readme.txt file.

The following function changes two settings for each theme.
You can test the settings at http://02d.in/
Register as a user then select a theme in your user profile.

The code is based on the user theme setting. The user theme setting is empty when the user
selects the site default.

Some themes have a unique id in a division containing the ul list
and have only a class in the ul element. This code looks for the id in the container
then a class in the ul.

a3_atlantis: <div id="nav"><ul id="navlist" class="links">
bluemarine: <td id="menu"><ul id="navlist" class="links">
garland: <div id="header"><ul class="links primary-links">
lemontwist: <div id="primary"><ul id="navlist" class="links">
litejazz-6.x-1.7:

<div id="navigation" class="menu withprimary ">
                      <div id="primary" class="clear-block"><ul class="menu"><ul class="menu">

minnelli: <div id="header"><ul class="links primary-links">
pixture_reloaded: <div id="primary"><div id="primary-inner"><ul class="links">
zen_classic: <div id="primary" class="clear-block"><ul class="links">

Comment #5

peterx CreditAttribution: peterx commented 23 January 2009 at 01:30

The most common theme arrangement is to have a containing div with an id of #primary then a ul with a class of links. Garland and derivatives use a container id of header. If everyone agreed on the same container id and class, the code would work with no special changes.

I could use the class of links by itself but some themes use links in several places and some use links for other purposes.

I could add an API so a theme can register the container id and the class. There could be an option to have the id on the ul element.

I could, one day in the distant future, add code to add a superfish option to every theme. I prefer to request the change be added into Drupal 7 core. http://drupal.org/node/362914

Comment #6

pokadan CreditAttribution: pokadan commented 24 January 2009 at 11:32

@petrex
Just registered with your site to see if you got the module working in a theme. I cannot set my theme on my profile and since your default theme does not support drop down menus I'm going to suppose your module doesn't work.

Comment #7

peterx CreditAttribution: peterx commented 25 January 2009 at 07:35

I forgot to give registered users the option of selecting a theme. You now have that option. I also changes the site default theme to Litejazz.

I also did not have a child entry in the menu. There is now one menu entry with children and it is set to expanded. You can see superfish in action on top of Litejazz.

The CSS could use some fine tuning. The superfish module does not attempt to change the theme CSS to match superfish. The idea is to make superfish available easily, and match CSS to superfish instead of one version of suckerfish. With Superfish in core, the superfish CSS would load before the theme CSS and the theme could easily override the superfish CSS.

Comment #8

pokadan CreditAttribution: pokadan commented 25 January 2009 at 14:01

Ok, i've seen how it works. It more like "it shows" than "it works" but that has more to do with css stuff(like you pointed out). Not sure if it belongs in core but a module to handle SuperFish(as opposed to Suckerfish) menus would come in handy to those who have issues with suckerfish woring in IE browsers. Just check http://drupal.org/search/node/nice+menu+IE there are around 70 different issues with nice menus and IE browsers.

I've figured out a way to integrate Superfish drop down menus with a D6 theme(most likely any theme). It works flawlessly in FF3(I believe FF2 as well), IE6, IE7, IE8 beta 2. Creating a module would be something else as the displaying theme would have to play nicely with the module.

Comment #9

roopletheme CreditAttribution: roopletheme commented 29 January 2009 at 09:03

Status:

Active

» Postponed

I've got a generic superfish module that I've used on a few client sites. However, I have yet to clean it up to the state where I felt it was ready for contribution. Furthermore, I got a bit of resistance to the idea when I pitched it on the IRC channel a few months back because some people felt that it duplicated functionality of other modules. I've been out of the loop for a few months and I'm not up on the current state of those modules... I'll catch up and make a decision asap. In the mean time, you can take a look at http://demo.roopletheme.com/superfish. Feel free to contact me if you want the module in its current state.

Comment #10

peterx CreditAttribution: peterx commented 29 January 2009 at 11:01

I love the superfish demo with fade fast. Fast and does not distract by leading the eye down the list. I cannot see anything it duplicates from other modules. Even if it did, we have dozens of modules that duplicate each other with just minor differences. Those minor differences are what makes a module ideal for a Web site builder who does not have the knowledge required to go into module code to create those changes.

Themes are more duplicitous than modules with some themes doing little more than changing an image or a colour. The important point is that someone can use a variation out of the box without breaking the layout when trying to make a minor change. There are lots of menues duplicating suckerfish with home built code and none provide the range of standard features available from jQuery, Superfish, and the standard supplements. I am all for putting a superfished Garland in core so that a superfish module is added to Drupal core.

It would be easier for me to work with your module than try to add fade or anything to my basic attempt. Where can I download your Superfish module?

Comment #11

roopletheme CreditAttribution: roopletheme commented 29 January 2009 at 16:57

As I mentioned, it's not really ready for prime time. But it's very functional, and I've used it on several sites and with several custom themes. I'm wary of posting a download link because I'm not really prepared to provide anything in the way of support for the module in its current state. But with that in mind, I'd be happy to share it with anyone who's willing to figure things out for themselves. Hit me up via my contact form and I'll hook you up.

Comment #12

bwv CreditAttribution: bwv commented 6 February 2009 at 14:43

roopletheme: just a quick thank you for sharing your module. it works flawlessly and is a brilliant piece of coding.

http://classicvinyl.biz (at the very top)

best, david

Comment #13

bwv CreditAttribution: bwv commented 7 February 2009 at 13:28

File	Size
super.jpg	167.7 KB

I'm having some trouble with the superfish menus in IE5.5 and IE6; please have a look at the screenshot, and in particular the white background visible beneath the vertical listings. Any clues as to how I might remedy this? Many thanks

UPDATE: I disabled superfish temporarily from my main record store site (http://classicvinyl.biz) as it has been reported that the site was loading slowly (http://drupal.org/node/362914). I am trying to determine which browsers are affected. I think only IE 5 and 6, but if anyone has experience they can share I'd appreciate hearing it. Thanks.

NOTE: You can see superfish activated on another site I run -- http://music.classicvinyl.biz (at the top)

Comment #14

agerson CreditAttribution: agerson commented 20 June 2009 at 20:53

I have noticed that superfish, even set on the fast animation speed, has a slight pause before it shows the drop down. Suckerfish did not have this. Is there a fix for superfish?