This has been bothering me for a long time (applies to 6.x also), there's a completely unnecessary unset($edit) right in the middle of _form_builder_handle_input_element(). It's not defined earlier in the function, nor is it a static variable or passed in by reference. It's just a small bit of cruft, supposedly left over from #138706: FormAPI 3: Ready to rock.

CommentFileSizeAuthor
#1 drupal_form_inc_unnecessary_unset.patch513 bytesquicksketch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
FileSize
drupal_form_inc_unnecessary_unset.patch513 bytes

Attached.

eaton’s picture

eaton CreditAttribution: eaton commented

There's no reason that line should live. Good catch, quicksketch!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Version: 7.x-dev » 6.x-dev
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Confirmed that $edit is not defined earlier in the function, and testing bot is happy.

It is now dead in HEAD! Thanks. :)

Moving to 6.x.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6 too!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for two weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.