Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Image cache module documentation recomends using the transliteration module and altering the theme_imagecache function. Going this way prevents a clean update of the image cache module since it is necessary to edit the file after each update.
As the altered theme_imagecache function checks the existence of the transliteration module it makes no harm to include this function by default in the image cache module.
Comment | File | Size | Author |
---|---|---|---|
#13 | imagecache_357569.patch | 905 bytes | drewish |
#5 | imagecache_with_transliteration.patch | 789 bytes | thePanz |
#4 | imagecache.module.patch | 592 bytes | smitty |
Comments
Comment #1
deleuje CreditAttribution: deleuje commentedGood idea. I second this.
Comment #2
drewish CreditAttribution: drewish commentedroll a patch. as it is i'm happy with just recommending this.
Comment #3
rbl CreditAttribution: rbl commentedHi!
The theme_imagecache function in the module looks more complex than the one on the documentation page.
Is that code up to date?
Thanks!
Ricardo
Comment #4
smitty CreditAttribution: smitty commentedHere comes a patch. I've tested it only whith the 5.x-2.3 version. But it should also work with the 6.x-2.0-beta8.
Comment #5
thePanz CreditAttribution: thePanz commentedComment #6
apaderno+1 for the feature; as there is already a module that handles the transliteration of the strings used in Drupal, it would be better to use that module to avoid the duplication of existing code.
Then, the code to keep updated in case of bugs would be reduced.
Comment #7
smitty CreditAttribution: smitty commentedI think, the patches #4 and #5 are identical.
Comment #8
apadernoActually, they aren't; the initial offset reported is different (775,6 versus 697,6).
Comment #9
thePanz CreditAttribution: thePanz commented@smitty: I took the edits from #4 and changed the 6.x module version, nothing more! :)
Comment #10
smitty CreditAttribution: smitty commentedFine! Then we have a patch for Drupal 5.x (#4) and for Drupal 6.x (#5).
Comment #11
drewish CreditAttribution: drewish commentedmarked #369193: Image src not properly URL encoded #447156: Needing only a url from imagecache as a duplicates.
Comment #12
thePanz CreditAttribution: thePanz commented@drewish: we'll see this patch merged in next -beta10 release?
Comment #13
drewish CreditAttribution: drewish commentedi think this might be a better place to put it.
Comment #14
drewish CreditAttribution: drewish commentedcommitted to HEAD.
Comment #15
smitty CreditAttribution: smitty commentedWill there be a rollback to 5.x?
Comment #16
drewish CreditAttribution: drewish commentedyeah, going to fold that into the backport of #347566: Require transliteration module.