This can be improved:

// $Id: browscap.module,v 1.6.2.3.2.4 2008/08/13 02:49:43 robloach Exp $
PHP Notice:  Trying to get property of non-object in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 257
PHP Notice:  Trying to get property of non-object in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 259
PHP Notice:  Undefined index:  parent in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 90
PHP Notice:  Undefined index:  crawler in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 95
Files: 
CommentFileSizeAuthor
#6 360347_6_browscap_notices.patch3.77 KBgreggles
#3 blah.patch2.65 KBRobLoach

Comments

Category:feature» task

Status:Active» Needs review
StatusFileSize
new2.65 KB

Title:Trying to get property of non-objectPHP Notice: Trying to get property of non-object
Category:task» bug

StatusFileSize
new3.77 KB

Here's the same patch merged with some other php notices I found.

However, I was never able to reproduce the original issue here. What are the steps to repeat?

Status:Needs review» Fixed

I looked at the code some more and it seems reasonable - http://drupal.org/cvs?commit=264084

(Also, I didn't want to have to merge a bunch of stuff as I work on other patches ;) )

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.