On my site that runs project I want to use the advanced_help module to provide information on what it means for a release to be supported, recommended, etc. I also don't need the scary looking warnings like we use. I could easily override theme_project_release_download_table_row() to get what I want, but of course it would be better if I could override less code so that I don't have to update my overridden function whenever we change theme_project_release_download_table_row().

Also, the code as is treats the snapshot condition and the unsupported condition as the same (red background, red 'X' icon), which might not be desirable on other sites.

This patch reworks theme_project_release_download_table_row() a little to decrease the amount of code and simplify it a little, and also changes the classes used for coloring the table to be more descriptive about what type of release it is, not how we want to display that release (eg. instead of a class of 'warning' we now use 'supported').

The attached patch is only for D5, though I doubt it will take much to get it working for D6. I also rolled it from /project/release not /project because my project module is patched.

I'd like some comments on the approach used here. If people are cool with doing this, I'll reroll appropriately and also work on a D6 version so we can commit to HEAD first/at the same time.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

+1 from me. I like the direction. Feel free to roll this for HEAD and we can get it in. I'm slightly hesitant to commit to D5, only since sites that have already themed this stuff will be broken again. But, if you really want it in D5, I'd be ok with that, too. ;)

Thanks,
-Derek

aclight’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Active » Needs review
FileSize
5.61 KB

Here's a patch for HEAD. It'd be nice for me to get this in D5 since that's what I'm using at the moment and that means I'd need to keep track of fewer patches, but your point is also valid. Either way is fine with me. I briefly tested this D6 patch and all seems to be working properly.

aclight’s picture

Issue tags: +6.x-1.0 blocker

Adding as a blocker for 6.x-1.x release so that the point in comment 1 won't also be applicable to the 6.x-1.x branch if we release before this gets in.

hass’s picture

Issue summary: View changes

Please check out 7.x if the issue has been improved and may close it has D6 version is going out of support soon.

drumm’s picture

Status: Needs review » Closed (won't fix)

Yes, the table is a View in 7.x, so there are lots of opportunities to modify or completely override the output.