Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This functionality is forked off of #371374: Add ImageCache UI Core and based on code that's been in ImageCache for quite a while.
Comment | File | Size | Author |
---|---|---|---|
#12 | filefield_363960.patch | 879 bytes | drewish |
#13 | file_373502.patch | 9.13 KB | drewish |
#11 | file_373502.patch | 9.13 KB | drewish |
#10 | file_373502.patch | 7.9 KB | drewish |
#9 | drupal7-sun.file-delete-recursive___.patch | 7.94 KB | sun |
Comments
Comment #2
drewish CreditAttribution: drewish commentedfixing a bug in the tests and a missed replacement of simpletest_clean_temporary_directory() with file_unmanaged_delete_recursive().
Comment #3
sunStraightforward. Only very minor issues:
...I had to read twice to understand.
Doubled blank lines in file.test.
If the tests will pass and those very minor issues are fixed, this is RTBC.
Comment #4
drewish CreditAttribution: drewish commentedthanks sun, fixed those issues.
Comment #5
sunWe can also provide some return value. Slightly simplified that comment.
Comment #6
drewish CreditAttribution: drewish commentedsun, i intentionally did not return a value since you'd really need to check the whole way down the tree.
Comment #7
sunRemoved the return value.
But also fixed some coding-style issues. Yikes!
Comment #8
sunComment #9
sunComment #10
drewish CreditAttribution: drewish commentedhow about this so we avoid checking is_file is_link over and over?
Comment #11
drewish CreditAttribution: drewish commentedokay, now with return value. and better docs.
Comment #12
drewish CreditAttribution: drewish commentedwhat a beautiful bikeshed we've built!
[ignore this... wrong patch]
Comment #13
drewish CreditAttribution: drewish commentedwith an extra the now.
Comment #14
sunComment #15
webchickExcellent work, folks. :) Committed to HEAD.