With 4.7 coming up, it seemed like a good time to dive in with the links bundle. I've attached a patch that begins the work of updating the module for 4.7, though I don't yet understand some of the code enough to complete it yet.

The link settings forms should all be working, and the nodeapi 'attached links' form in links_related.module is now working and building properly. The sub-functions that handle validating, saving, and loading assorted links still need work however and most of those are in links.inc.

This patch is NOT ready for prime time, and should only be used as a starting point for further development -- I wanted to get it posted here sooner rather than later in case someone else is already working on, or considering working on, a 4.7 conversion for it.

CommentFileSizeAuthor
#5 links.module_admin_form.patch6.8 KBdrewish
links_bundle.patch20.15 KBeaton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented
Assigned: Unassigned » syscrusher

Eaton, you ROCK! I've been terribly busy, and was dreading the need to take this task on. I'm reviewing your patch now. Thank you!

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented
Status: Needs work » Active

Committed in CVS, and some additional conversion work done on the part you didn't have time to do. Again, THANKS so very much for this major contribution. You made my day!

Scott

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented
Category: bug » task

I should mention, by the way, that preliminary testing has this new code mostly working as it should. I found a couple of small bugs, and a couple of places I want to better exploit new API features, but overall, this is a big step forward.

Scott

eaton’s picture

eaton CreditAttribution: eaton commented

Awesome news! If there's anything I can do to help, let me know. I can imagine a number of applications where this API would be useful, and I'm only now just making the transition from weblinks.module.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Active » Needs work
FileSize
links.module_admin_form.patch6.8 KB

I've done a bit more on the admin/links form. Now it uses the whole _form()/_theme()/_execute() model.
I setup the basics to have get the themed table working right. I haven't gotten the execute part working because I don't have any links in my database (see my other patch to the weblink module). I'll start working on this again after I get that stright.

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

I think this is all committed into CVS. Please grab the HEAD version and check to make sure I got the right version of your code, and that I didn't miss anything. Thanks very much for the contribs!

Scott

Steve Dondley’s picture

Steve Dondley CreditAttribution: Steve Dondley commented

I was looking into this problem myself. I'm not sure this patch is good probably should not have been applied. For one, it uses hook_execute which is a nodeapi hook, not for forms. For forms, hook_submit should be used.

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

Hi, folks.

Just wanted to let you know, I'm fighting a major problem with a production server. It may be another day or two before I get time to work on Drupal code, but I wanted to let you know I haven't vanished.

Scott (syscrusher)

syscrusher’s picture

syscrusher CreditAttribution: syscrusher commented

I'm baaaaaa---aaaaaack! Finally got that server migrated to the replacement machine, and will be working on this and other issues ASAP. Thanks for your patience.

Scott