Per #140860: Consistent table names and database handling of table names.

Update hook intended to go after #375367: Make session table singular

CommentFileSizeAuthor
#9 blocked_ip_tables_singular.patch9.09 KBboombatower
#5 blocked_ip_tables_singular.patch10.8 KBboombatower
blocked_ip_tables_singular.patch9.07 KBboombatower
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

recidive’s picture

recidive CreditAttribution: recidive commented
Status: Needs review » Needs work

As explained in #330983-15: Rename user module tables to singular, upgrade path will not work.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs work » Needs review

OK, couple things:

1.) This patch ignores the update hooks in the modules/system/system.install (Please confirm and explain)
2.) The ip blocking tests in system still run great, but I should probably be tested fully. I've had trouble getting all my tests to run properly on my system, so let's get some feedback on #1 and I'll get my tests working and try with the full set.

Eclipse

boombatower’s picture

boombatower CreditAttribution: boombatower commented

1) I left them on purpose since they will all run and then the table name will be altered...as that is the standard upgrade path method, but I suppose that only applies when developing a released Drupal...as that would be HEAD-HEAD. Still need to order the updates in some fashion.

2) Bot ran whole sweet and that worked...lets discuss the solution to #1 in the main topic #140860: Consistent table names and database handling of table names.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs work » Needs review
FileSize
blocked_ip_tables_singular.patch10.8 KB

Upgrade must also take place in hard-coded update.php due to the low-level nature of the tables.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work 
+  if (db_table_exists('blocked_ips')) {
+    db_rename_table($ret, 'blocked_ips', 'blocked_ip');
+  }
+

No need for HEAD-HEAD upgrade.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs work » Needs review

That is for D6 -> D7 upgrade...which has to be in upgrade.php due to its low-level nature. @see http://drupal.org/node/140860#comment-1264426 and below.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

There's no blocked IPs table in D6 though.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs work » Needs review
FileSize
blocked_ip_tables_singular.patch9.09 KB

@catch: good point :)

Status: Needs review » Needs work

The last submitted patch failed testing.

drewish’s picture

drewish CreditAttribution: drewish commented
Version: 7.x-dev » 8.x-dev

Or perhaps won't fix?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

This has been moved into the Ban module, and the table renamed to ban_ip.