Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Per #140860: Consistent table names and database handling of table names.
Update hook intended to go after #375367: Make session table singular
Comment | File | Size | Author |
---|---|---|---|
#9 | blocked_ip_tables_singular.patch | 9.09 KB | boombatower |
#5 | blocked_ip_tables_singular.patch | 10.8 KB | boombatower |
blocked_ip_tables_singular.patch | 9.07 KB | boombatower | |
Comments
Comment #1
recidive CreditAttribution: recidive commentedAs explained in #330983-15: Rename user module tables to singular, upgrade path will not work.
Comment #2
EclipseGc CreditAttribution: EclipseGc commentedOK, couple things:
1.) This patch ignores the update hooks in the modules/system/system.install (Please confirm and explain)
2.) The ip blocking tests in system still run great, but I should probably be tested fully. I've had trouble getting all my tests to run properly on my system, so let's get some feedback on #1 and I'll get my tests working and try with the full set.
Eclipse
Comment #3
boombatower CreditAttribution: boombatower commented1) I left them on purpose since they will all run and then the table name will be altered...as that is the standard upgrade path method, but I suppose that only applies when developing a released Drupal...as that would be HEAD-HEAD. Still need to order the updates in some fashion.
2) Bot ran whole sweet and that worked...lets discuss the solution to #1 in the main topic #140860: Consistent table names and database handling of table names.
Comment #5
boombatower CreditAttribution: boombatower commentedUpgrade must also take place in hard-coded update.php due to the low-level nature of the tables.
Comment #6
catchNo need for HEAD-HEAD upgrade.
Comment #7
boombatower CreditAttribution: boombatower commentedThat is for D6 -> D7 upgrade...which has to be in upgrade.php due to its low-level nature. @see http://drupal.org/node/140860#comment-1264426 and below.
Comment #8
catchThere's no blocked IPs table in D6 though.
Comment #9
boombatower CreditAttribution: boombatower commented@catch: good point :)
Comment #11
drewish CreditAttribution: drewish commentedOr perhaps won't fix?
Comment #12
jhedstromThis has been moved into the Ban module, and the table renamed to
ban_ip
.